@@ -, +, @@ --- C4/CourseReserves.pm | 1 + t/db_dependent/CourseReserves.t | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) --- a/C4/CourseReserves.pm +++ a/C4/CourseReserves.pm @@ -77,6 +77,7 @@ This module deals with course reserves. sub GetCourse { my ($course_id) = @_; warn whoami() . "( $course_id )" if $DEBUG; + return unless $course_id; my $query = "SELECT * FROM courses WHERE course_id = ?"; my $dbh = C4::Context->dbh; --- a/t/db_dependent/CourseReserves.t +++ a/t/db_dependent/CourseReserves.t @@ -5,8 +5,7 @@ use Modern::Perl; -use Test::More tests => 20; -use Data::Dumper; +use Test::More tests => 21; BEGIN { use_ok('C4::Biblio'); @@ -46,12 +45,13 @@ $course_id = ModCourse( ); my $course = GetCourse($course_id); - ok( $course->{'course_name'} eq "Test Course", "GetCourse returned correct course" ); ok( $course->{'staff_note'} eq "Test staff note 2", "ModCourse updated course succesfully" ); my $courses = GetCourses(); -ok( $courses->[0]->{'course_name'} eq "Test Course", "GetCourses returns valid array of course data" ); +is( ref($courses), 'ARRAY', "GetCourses returns an array" ); +my @match = map {$_->{course_name} eq 'Test Course'} @$courses; +ok( scalar(@match) > 0, "GetCourses returns valid array of course data" ); ModCourseInstructors( mode => 'add', course_id => $course_id, borrowernumbers => [ $borrowers[0]->{'borrowernumber'} ] ); $course = GetCourse($course_id); --