View | Details | Raw Unified | Return to bug 4319
Collapse All | Expand All

(-)a/C4/Reserves.pm (-11 / +2 lines)
Lines 1143-1160 sub IsAvailableForItemLevelRequest { Link Here
1143
        }
1143
        }
1144
1144
1145
        return $any_available ? 0 : 1;
1145
        return $any_available ? 0 : 1;
1146
    } else { # on_shelf_holds == 0 "If any unavailable" (the description is rather cryptic and could still be improved)
1147
        return $item->{onloan} || IsItemOnHoldAndFound( $item->{itemnumber} );
1146
    }
1148
    }
1147
1148
    if ($item->{onloan}) {
1149
        return 1;
1150
    }
1151
1152
    if ( Koha::Holds->search({itemnumber => $item->{itemnumber},
1153
                              found => ['W', 'T']})->count ) {
1154
        return 1;
1155
    }
1156
1157
    return 0;
1158
}
1149
}
1159
1150
1160
=head2 OnShelfHoldsAllowed
1151
=head2 OnShelfHoldsAllowed
(-)a/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t (-7 / +1 lines)
Lines 7-13 use C4::Items; Link Here
7
use C4::Circulation;
7
use C4::Circulation;
8
use Koha::IssuingRule;
8
use Koha::IssuingRule;
9
9
10
use Test::More tests => 7;
10
use Test::More tests => 6;
11
11
12
use t::lib::TestBuilder;
12
use t::lib::TestBuilder;
13
use t::lib::Mocks;
13
use t::lib::Mocks;
Lines 255-264 $rule->store(); Link Here
255
$is = IsAvailableForItemLevelRequest( $item3, $borrower1);
255
$is = IsAvailableForItemLevelRequest( $item3, $borrower1);
256
is( $is, 1, "Item can be held, items in transit are not available" );
256
is( $is, 1, "Item can be held, items in transit are not available" );
257
257
258
Koha::Holds->find($hold->{reserve_id})->found('F')->store;
259
260
$is = IsAvailableForItemLevelRequest( $item3, $borrower1);
261
is( $is, 0, "Item is neither waiting nor in transit." );
262
263
# Cleanup
258
# Cleanup
264
$schema->storage->txn_rollback;
259
$schema->storage->txn_rollback;
265
- 

Return to bug 4319