Bugzilla – Attachment 104682 Details for
Bug 8132
Batch delete tool deletes items with holds on them
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8132: Fix failing tests
Bug-8132-Fix-failing-tests.patch (text/plain), 2.02 KB, created by
Jonathan Druart
on 2020-05-11 10:45:45 UTC
(
hide
)
Description:
Bug 8132: Fix failing tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-05-11 10:45:45 UTC
Size:
2.02 KB
patch
obsolete
>From 47646897876fc80530279caa881ab81d5bd6b35a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 11 May 2020 12:43:06 +0200 >Subject: [PATCH] Bug 8132: Fix failing tests > >* Add missing html filter (xt/find-missing-filters.t) >* Fix AddReserve call >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt | 2 +- > t/db_dependent/Koha/Item.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >index f15f213398..eb5ddd82c6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >@@ -258,7 +258,7 @@ > [% CASE "last_item_for_hold" %][% SET cannot_delete_reason = t("Last item for bibliographic record wich biblio-level hold on it") %] > [% CASE %][% SET cannot_delete_reason = t("Unknown reason") _ '(' _ can_be_deleted _ ')' %] > [% END %] >- [% cannot_delete_reason %] >+ [% cannot_delete_reason | html %] > </td> > </tr> > [% END %] >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index 517126130c..581c96d776 100644 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -431,7 +431,7 @@ subtest 'deletion' => sub { > } > > { # last_item_for_hold >- C4::Reserves::AddReserve($patron->branchcode, $patron->borrowernumber, $item->biblionumber ); >+ C4::Reserves::AddReserve({ branchcode => $patron->branchcode, borrowernumber => $patron->borrowernumber, biblionumber => $item->biblionumber }); > is( $item->safe_to_delete, 'last_item_for_hold', 'Item cannot be deleted if a biblio-level is placed on the biblio and there is only 1 item attached to the biblio' ); > > # With another item attached to the biblio, the item can be deleted >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8132
:
95936
|
95937
|
95938
|
95939
|
95997
|
96147
|
96148
|
96149
|
96150
|
98694
|
98695
|
98696
|
98697
|
101404
|
101405
|
101406
|
101407
|
103147
|
103148
|
103149
|
103150
|
103166
|
103167
|
103168
|
103169
|
104567
|
104568
|
104569
|
104570
|
104571
| 104682