Bugzilla – Attachment 10892 Details for
Bug 7189
preference to control if returning lost items gives refund
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7189 - preference to control if returning lost items gives refund
0001-Bug-7189-preference-to-control-if-returning-lost-ite.patch (text/plain), 4.56 KB, created by
Jonathan Druart
on 2012-07-17 13:47:35 UTC
(
hide
)
Description:
Bug 7189 - preference to control if returning lost items gives refund
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-07-17 13:47:35 UTC
Size:
4.56 KB
patch
obsolete
>From 6f8f0e5558809816a575a5a07de9fdface7b1ad2 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 24 Apr 2012 09:05:36 -0400 >Subject: [PATCH 1/1] Bug 7189 - preference to control if returning lost items > gives refund > >Right now when you return an item that was lost the patron's card is >credited with the lost fee, but not all libraries refund lost fees >and sometimes the fee is refunded after the patron has paid for it, >causing all kinds of financial issues. > >Adds the syspref RefundLostItemFeeOnReturn to control whether >returning a lost item refunds the fee charged for losing that >item. Enabled by default to maintain Koha's current functionality. >--- > C4/Circulation.pm | 4 +++- > installer/data/mysql/sysprefs.sql | 1 + > installer/data/mysql/updatedatabase.pl | 7 +++++++ > .../en/modules/admin/preferences/circulation.pref | 6 ++++++ > 4 files changed, 17 insertions(+), 1 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index efb720b..8b08f7c 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1069,7 +1069,9 @@ sub AddIssue { > > ## If item was lost, it has now been found, reverse any list item charges if neccessary. > if ( $item->{'itemlost'} ) { >- _FixAccountForLostAndReturned( $item->{'itemnumber'}, undef, $item->{'barcode'} ); >+ if ( C4::Context->preference('RefundLostItemFeeOnReturn' ) ) { >+ _FixAccountForLostAndReturned( $item->{'itemnumber'}, undef, $item->{'barcode'} ); >+ } > } > > ModItem({ issues => $item->{'issues'}, >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 7009155..72eb580 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -375,3 +375,4 @@ INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ( > INSERT INTO systempreferences (variable,value,explanation,type) VALUES('EnableBorrowerFiles','0','If enabled, allows librarians to upload and attach arbitrary files to a borrower record.','YesNo'); > INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('UpdateTotalIssuesOnCirc','0','Whether to update the totalissues field in the biblio on each circ.',NULL,'YesNo'); > INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('IntranetSlipPrinterJS','','Use this JavaScript for printing slips. Define at least function printThenClose(). For use e.g. with Firefox PlugIn jsPrintSetup, see http://jsprintsetup.mozdev.org/','','Free'); >+INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('RefundLostItemFeeOnReturn', '1', 'If enabled, the lost item fee charged to a borrower will be refunded when the lst item is returned.', NULL, 'YesNo'); >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index bb96644..01ab437 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -5536,6 +5536,13 @@ if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { > SetVersion($DBversion); > } > >+$DBversion = "3.09.00.XXX"; >+if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { >+ $dbh->do("INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('RefundLostItemFeeOnReturn', '1', 'If enabled, the lost item fee charged to a borrower will be refunded when the lst item is returned.', NULL, 'YesNo')"); >+ print "Upgrade to $DBversion done ( Add system preference RefundLostItemFeeOnReturn )\n"; >+ SetVersion($DBversion); >+} >+ > =head1 FUNCTIONS > > =head2 TableExists($table) >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index e07fc0d..b3e9acd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -393,6 +393,12 @@ Circulation: > test: Calculate (but only for mailing to the admin) > production: Calculate and charge > - fines (when <code>misc/cronjobs/fines.pl</code> is being run). >+ - >+ - pref: RefundLostItemFeeOnReturn >+ choices: >+ yes: Refund >+ no: "Don't refund" >+ - lost item fees charged to a borrower when the lost item is returned. > Self Checkout: > - > - pref: ShowPatronImageInWebBasedSelfCheck >-- >1.7.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7189
:
9283
|
10614
|
10892
|
10951
|
10971
|
10974
|
11005
|
11054