Bugzilla – Attachment 111379 Details for
Bug 26634
Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26634: Do not reorder effective rules
Bug-26634-Do-not-reorder-effective-rules.patch (text/plain), 1.76 KB, created by
Andrew Fuerste-Henry
on 2020-10-08 15:36:41 UTC
(
hide
)
Description:
Bug 26634: Do not reorder effective rules
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2020-10-08 15:36:41 UTC
Size:
1.76 KB
patch
obsolete
>From aa68f6768c659454a393b243833ea44af545f005 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >Date: Thu, 8 Oct 2020 15:34:08 +0000 >Subject: [PATCH] Bug 26634: Do not reorder effective rules > >To test: >1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold >2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds >3 - confirm ReservesControll is set to patron's library >4 - find a patron from Branch A of the category for which you made your rule >5 - find two bibs with items of the itype got which you made your rule >6 - place a hold on one bib. success! >7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold >8 - apply patch, restart services >9 - try to place your second hold again, success! >--- > C4/Reserves.pm | 6 ------ > 1 file changed, 6 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 2422d4facd..8272c771c2 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -2245,9 +2245,6 @@ sub GetHoldRule { > categorycode => $categorycode, > branchcode => $branchcode, > rule_name => 'reservesallowed', >- order_by => { >- -desc => [ 'categorycode', 'itemtype', 'branchcode' ] >- } > } > ); > >@@ -2265,9 +2262,6 @@ sub GetHoldRule { > categorycode => $categorycode, > branchcode => $branchcode, > rules => ['holds_per_record', 'holds_per_day'], >- order_by => { >- -desc => [ 'categorycode', 'itemtype', 'branchcode' ] >- } > } > ); > $rules->{holds_per_record} = $holds_per_x_rules->{holds_per_record}; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26634
:
111379
|
111383
|
111398
|
113966
|
114017
|
114260
|
114439
|
116519