Bugzilla – Attachment 113653 Details for
Bug 26940
debarred comment in borrowers table is lost on patron modifications in memberentry.pl page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26940: don't reset debarredcomment on patron update
Bug-26940-dont-reset-debarredcomment-on-patron-upd.patch (text/plain), 1.89 KB, created by
Martin Renvoize (ashimema)
on 2020-11-16 09:44:44 UTC
(
hide
)
Description:
Bug 26940: don't reset debarredcomment on patron update
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-11-16 09:44:44 UTC
Size:
1.89 KB
patch
obsolete
>From 950d910cc2588d5ebf96688013797abd08f8ece0 Mon Sep 17 00:00:00 2001 >From: Didier Gautheron <didier.gautheron@biblibre.com> >Date: Thu, 5 Nov 2020 15:04:41 +0100 >Subject: [PATCH] Bug 26940: don't reset debarredcomment on patron update > >Test plan: >1) Create a patron >2) In koha/members/moremember.pl add a manual restriction, with comment foobar >3) try to checkout, you have a message like > Restricted: Patron's account is restricted with the explanation: > foobar >4) Got to Edit patron, save >5) try to checkout, foobar is no more > Restricted: Patron's account is restricted with the explanation: >6) Apply patch >7) Redo 1-4 >8) try to checkout, foobar is there. > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > members/memberentry.pl | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 221026acb9..a4a33e34e5 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -243,7 +243,7 @@ if ( $op eq 'insert' || $op eq 'modify' || $op eq 'save' || $op eq 'duplicate' ) > qr/^\d+-DAYS/, > qr/^patron_attr_/, > qr/^csrf_token$/, >- qr/^add_debarment$/, qr/^debarred_expiration$/, qr/^remove_debarment$/, # We already dealt with debarments previously >+ qr/^add_debarment$/, qr/^debarred_comment$/,qr/^debarred_expiration$/, qr/^remove_debarment$/, # We already dealt with debarments previously > qr/^housebound_chooser$/, qr/^housebound_deliverer$/, > qr/^select_city$/, > qr/^new_guarantor_/, >@@ -531,8 +531,6 @@ if ((!$nok) and $nodouble and ($op eq 'insert' or $op eq 'save')){ > delete $newdata{'B_email'}; > } > >- $newdata{debarredcomment} = $newdata{debarred_comment}; >- delete $newdata{debarred_comment}; > delete $newdata{password2}; > > eval { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26940
:
113119
|
113123
|
113653
|
113702
|
113779
|
118500
|
118501
|
118502
|
119778
|
119779
|
119780