Attachment 11384 Details for Bug 4064 – [SIGNED-OFF] Bug 4064 - Uninitialized variable errors in opac-search.pl Merely optimized two if statements, already fixed in master.

[patch] [SIGNED-OFF] Bug 4064 - Uninitialized variable errors in opac-search.pl Merely optimized two if statements, already fixed in master.

0001-Bug-4064-Uninitialized-variable-errors-in-opac-searc.patch (text/plain), 1.49 KB, created by Julian Maurice on 2012-08-06 13:37:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2012-08-06 13:37:16 UTC

Size: 1.49 KB

patch

obsolete

>From edf452f6de0eb387b7f3cbb7532a3d0141174151 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Sat, 30 Jun 2012 13:45:25 +0800
>Subject: [PATCH] Bug 4064 - Uninitialized variable errors in opac-search.pl
> Merely optimized two if statements, already fixed in
> master.
>
>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> opac/opac-search.pl |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/opac/opac-search.pl b/opac/opac-search.pl
>index 1e5a0d7..be96d8e 100755
>--- a/opac/opac-search.pl
>+++ b/opac/opac-search.pl
>@@ -609,7 +609,7 @@ for (my $i=0;$i<@servers;$i++) {
> 
>             if (!$borrowernumber || $borrowernumber eq '') {
>                 # To a cookie (the user is not logged in)
>-                if (($params->{'offset'}||'') eq '') {
>+                if (!$offset) {
>                     push @recentSearches, {
>                                 "query_desc" => $query_desc_history || "unknown",
>                                 "query_cgi"  => $query_cgi_history  || "unknown",
>@@ -631,7 +631,7 @@ for (my $i=0;$i<@servers;$i++) {
>             }
>             else {
>                 # To the session (the user is logged in)
>-                if (($params->{'offset'}||'') eq '') {
>+                if (!$offset) {
>                     AddSearchHistory($borrowernumber, $cgi->cookie("CGISESSID"), $query_desc_history, $query_cgi_history, $total);
>                     $template->param(ShowOpacRecentSearchLink => 1);
>                 }
>-- 
>1.7.10.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 4064: 10572 | 11384 | 11948