Attachment 114568 Details for Bug 27290 – Bug 27290: Update 'type=number' to 'type=text inputmode=numeric'

[patch] Bug 27290: Update 'type=number' to 'type=text inputmode=numeric'

Bug-27290-Update-typenumber-to-typetext-inputmoden.patch (text/plain), 2.21 KB, created by Martin Renvoize (ashimema) on 2020-12-21 16:28:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-12-21 16:28:25 UTC

Size: 2.21 KB

patch

obsolete

>From 1c9793b2731dae8cc40aa0d780a5a1e6adee3a4f Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 21 Dec 2020 16:25:47 +0000
>Subject: [PATCH] Bug 27290: Update 'type=number' to 'type=text
> inputmode=numeric'
>
>This patch updates the inputs for the pay form on the point of sale page
>to use numeric inputmode. This appears to also fix the validation issue
>described in the bug report.
>
>To test:
>1 - Enable 'useCashRegisters' and 'EnablePointofSale'
>2 - Add a cash register
>3 - Add a debit type that can be sold
>4 - Go to point of sale and sell the item multiple times
>5 - Enter 'Amount tendered' less than amount being paid
>6 - Click confirm
>7 - Transaction is processed as if full funds received
>8 - Try with a negative number - goes through again
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>index 8d09c75df2..053bf6f075 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>@@ -112,11 +112,11 @@
>                         <ol>
>                             <li>
>                                 <label for="paid">Amount being paid: </label>
>-                                <input type="number" min="0.00" max="10000.00" step="0.01" name="paid" id="paid" value="[% amountoutstanding | $Price on_editing => 1 %]" readonly/>
>+                                <input type="text" inputmode="none" pattern="[0-9]" name="paid" id="paid" value="[% 0 | $Price %]" readonly/>
>                             </li>
>                             <li>
>                                 <label for="collected">Amount tendered: </label>
>-                                <input type="number" min="0.00" max="10000.00" step="0.01" name="collected" id="collected" value=""/>
>+                                <input type="number" inputmode="numberic" pattern="[0-9]" step="0.01" name="collected" id="collected" value="[% 0 | $Price on_editing => 1 %]"/>
>                             </li>
>                             <li>
>                                 <label>Change to give: </label>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27290: 114568 | 114670 | 114671 | 114747 | 114748 | 114749 | 114757 | 116389 | 116472