Bugzilla – Attachment 117832 Details for
Bug 26273
Expose cashup summary history for a cash register
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26273: (QA follow-up) Check for null firstname
Bug-26273-QA-follow-up-Check-for-null-firstname.patch (text/plain), 1.45 KB, created by
Katrin Fischer
on 2021-03-05 11:51:31 UTC
(
hide
)
Description:
Bug 26273: (QA follow-up) Check for null firstname
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-03-05 11:51:31 UTC
Size:
1.45 KB
patch
obsolete
>From 0af2b23578a2d80f18d057e1d4ed54067ea53bf3 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 5 Mar 2021 08:31:23 +0000 >Subject: [PATCH] Bug 26273: (QA follow-up) Check for null firstname > >This patch adds a test for firstname being defined before constructing >fullname from it. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >index e99c17a1ba..f392fa2da9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >@@ -437,7 +437,13 @@ > "searchable": true, > "orderable": true, > "render": function(data, type, row, meta) { >- var fullname = row.manager.firstname + " " + row.manager.surname; >+ var fullname; >+ if ( row.manager.firstname == null ) { >+ fullname = row.manager.surname; >+ } >+ else { >+ fullname = row.manager.firstname + " " + row.manager.surname; >+ } > return fullname; > } > }, >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26273
:
116176
|
116640
|
116685
|
116691
|
116692
|
116697
|
116698
|
116699
|
116710
|
116771
|
116772
|
116773
|
117449
|
117450
|
117451
|
117787
|
117793
|
117809
|
117810
|
117811
|
117829
|
117830
|
117831
|
117832
|
117833
|
117834
|
118125
|
118129
|
118130
|
118149
|
118150
|
118151
|
118152
|
120403
|
120404