Bugzilla – Attachment 118129 Details for
Bug 26273
Expose cashup summary history for a cash register
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26273: (QA follow-up) Use _escape_str/price for escaping
Bug-26273-QA-follow-up-Use-escapestrprice-for-esca.patch (text/plain), 1.94 KB, created by
Martin Renvoize (ashimema)
on 2021-03-11 14:29:58 UTC
(
hide
)
Description:
Bug 26273: (QA follow-up) Use _escape_str/price for escaping
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-03-11 14:29:58 UTC
Size:
1.94 KB
patch
obsolete
>From ab942f27fa4660a12831e0ea8ce902ee3e131e17 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 11 Mar 2021 13:55:00 +0000 >Subject: [PATCH] Bug 26273: (QA follow-up) Use _escape_str/price for escaping > >This patch moves the _escape_str and _escape_price functions into the >staff-global js include and then uses them in the register page >--- > .../intranet-tmpl/prog/en/modules/pos/register.tt | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >index 3b06a6eb4b..e40e782ffa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >@@ -414,15 +414,6 @@ > "manager" > ], > "order": [[ 0, "asc" ]], >- "columnDefs": [ { >- "targets": [0,1,2], >- "render": function (data, type, row, meta) { >- if ( type == 'display' ) { >- return data.escapeHtml(); >- } >- return data; >- } >- } ], > "columns": [ > { > "data": "timestamp", >@@ -444,7 +435,7 @@ > else { > fullname = row.manager.firstname + " " + row.manager.surname; > } >- return fullname; >+ return escape_str(fullname); > } > }, > { >@@ -453,7 +444,7 @@ > "orderable": true, > "render": function(data, type, row, meta) { > var amt = row.amount * -1; >- return (amt).format_price(); >+ return escape_price(amt); > } > }, > { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26273
:
116176
|
116640
|
116685
|
116691
|
116692
|
116697
|
116698
|
116699
|
116710
|
116771
|
116772
|
116773
|
117449
|
117450
|
117451
|
117787
|
117793
|
117809
|
117810
|
117811
|
117829
|
117830
|
117831
|
117832
|
117833
|
117834
|
118125
|
118129
|
118130
|
118149
|
118150
|
118151
|
118152
|
120403
|
120404