Bugzilla – Attachment 11948 Details for
Bug 4064
Uninitialized variable errors in opac-search.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Optimized two if statements (3.8.x)
0001-Bug-4064-Uninitialized-variable-errors-in-opac-searc.patch (text/plain), 1.65 KB, created by
Mark Tompsett
on 2012-09-04 00:37:34 UTC
(
hide
)
Description:
Optimized two if statements (3.8.x)
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2012-09-04 00:37:34 UTC
Size:
1.65 KB
patch
obsolete
>From eee54c0c7613a7de765a513754968c5b29d6bb10 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 4 Sep 2012 08:15:19 +0800 >Subject: [PATCH] Bug 4064 - Uninitialized variable errors in opac-search.pl >Content-Type: text/plain; charset="utf-8" > >In 3.6.3 the error was triggered. It was already fixed with some >particularly ugly logic: if (($params->{'offset'}||'') eq '') { >Having read through the code, $offset is a better choice and >produces prettier, clearer code: if (!$offset) { >--- > opac/opac-search.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index 5f3ad86..206bbf2 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -591,7 +591,7 @@ for (my $i=0;$i<@servers;$i++) { > # Adding the new search if needed > if (!$borrowernumber || $borrowernumber eq '') { > # To a cookie (the user is not logged in) >- if (($params->{'offset'}||'') eq '') { >+ if (!$offset) { > push @recentSearches, { > "query_desc" => $query_desc || "unknown", > "query_cgi" => $query_cgi || "unknown", >@@ -613,7 +613,7 @@ for (my $i=0;$i<@servers;$i++) { > } > else { > # To the session (the user is logged in) >- if (($params->{'offset'}||'') eq '') { >+ if (!$offset) { > AddSearchHistory($borrowernumber, $cgi->cookie("CGISESSID"), $query_desc, $query_cgi, $total); > $template->param(ShowOpacRecentSearchLink => 1); > } >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4064
:
10572
|
11384
| 11948