Bugzilla – Attachment 127680 Details for
Bug 29054
Stop warns from advance_notices.pl if not running in verbose mode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29054: Add verbose check for warn in advance_notices.pl
Bug-29054-Add-verbose-check-for-warn-in-advancenot.patch (text/plain), 1.51 KB, created by
Fridolin Somers
on 2021-11-16 07:37:15 UTC
(
hide
)
Description:
Bug 29054: Add verbose check for warn in advance_notices.pl
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2021-11-16 07:37:15 UTC
Size:
1.51 KB
patch
obsolete
>From 943924caa1b87b34df5363d87a08a40c3fc28907 Mon Sep 17 00:00:00 2001 >From: Hayley Pelham <hayleypelham@catalyst.net.nz> >Date: Mon, 20 Sep 2021 04:23:11 +0000 >Subject: [PATCH] Bug 29054: Add verbose check for warn in advance_notices.pl > >To test: >1) Set EnhancedMessagingPreferences to Don't allow >2) In the koha-shell, run misc/cronjobs/advance_notices.pl -c >3) Note that you see the warning "The "EnhancedMessagingPreferences" >syspref is off... etc." >4) Apply the patch and restart services >5) In the koha-shell, run misc/cronjobs/advance_notices.pl -c and note >the warning no longer shows >6) Still in the shell, run misc/cronjobs/advance_notices.pl -c -v and >note the warning does show > >Sponsored-by: Catalyst IT >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> >--- > misc/cronjobs/advance_notices.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl >index c1d6ac6672..1e894bde92 100755 >--- a/misc/cronjobs/advance_notices.pl >+++ b/misc/cronjobs/advance_notices.pl >@@ -209,7 +209,7 @@ pod2usage( -verbose => 2 ) if $man; > # Since advance notice options are not visible in the web-interface > # unless EnhancedMessagingPreferences is on, let the user know that > # this script probably isn't going to do much >-if ( ! C4::Context->preference('EnhancedMessagingPreferences') ) { >+if ( ! C4::Context->preference('EnhancedMessagingPreferences') && $verbose ) { > warn <<'END_WARN'; > > The "EnhancedMessagingPreferences" syspref is off. >-- >2.33.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29054
:
125086
|
127680
|
129242