Bugzilla – Attachment 13397 Details for
Bug 7932
twitter share doesn't work with socialnetworks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7932 [Revised] Twitter share doesn't work with socialnetworks
Bug-7932-Revised-Twitter-share-doesnt-work-with-so.patch (text/plain), 3.40 KB, created by
Owen Leonard
on 2012-11-12 15:48:21 UTC
(
hide
)
Description:
Bug 7932 [Revised] Twitter share doesn't work with socialnetworks
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2012-11-12 15:48:21 UTC
Size:
3.40 KB
patch
obsolete
>From 87b8335f3af2c7531fdce4267932220c87dede8d Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 1 Nov 2012 11:21:37 -0400 >Subject: [PATCH] Bug 7932 [Revised] Twitter share doesn't work with > socialnetworks >Content-Type: text/plain; charset="utf-8" > >The only way I can get this to work consistently is to use >Twitter's own code as documented here: > >https://dev.twitter.com/docs/tweet-button > >This requires that we use the tweet button generated by Twitter >rather than the smaller image we were using before. Using the >documented options for generating a custom button produced the >same inconsistent behavior this patch attempts to fix. > >Because of the change of appearance I moved the Twitter button >to last in line so that similarly-sized buttons were grouped. I >also changed the configuration of the Google+ button to exclude >the count, saving some horizontal space. > >Revision removes explicit declaration of share URL. I think when >testing this previously I assumed it was required when in fact >the share URL wasn't working because it was a localhost address. > >Localhost addresses are apparently rejected by Twitter. Testers >beware. >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index 1d0523a..fa1d6c9 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -8,6 +8,7 @@ > <script type="text/javascript" src="https://apis.google.com/js/plusone.js"> > {lang: '[% lang %]'} > </script> >+ <script type="text/javascript">!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script> > [% END %] > [% IF ( OpacStarRatings != 'disable' ) %]<script type="text/javascript" src="/opac-tmpl/prog/en/lib/jquery/plugins/jquery.rating.js"></script> > <link rel="stylesheet" type="text/css" href="/opac-tmpl/prog/en/css/jquery.rating.css" />[% END %] >@@ -1215,11 +1216,11 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > <div id="social_networks"> > <span>Share</span> > <div><a id="facebook" href="http://www.facebook.com/sharer.php?u=[% current_url |url %]&t=[% title |url %]" title="Share on Facebook">Facebook</a></div> >- <div><a id="twitter" href="http://twitter.com/share" title="Share on Twitter">Twitter</a></div> > <div><a id="linkedin" href="http://www.linkedin.com/shareArticle?mini=true&url=[% current_url |url %]&title=[% title |url %]" title="Share on LinkedIn">LinkedIn</a></div> > <div><a id="delicious" href="http://www.delicious.com/save?url=[% current_url |url %]&title=[% title |url %]" title="Share on Delicious">Delicious</a></div> > <div><a id="email" href="mailto:?subject=[% title |url %]&body=[% title |url %] ([% current_url |url %])" title="Share by email">Email</a></div> >- <div><g:plusone size="small"></g:plusone></div> >+ <div><g:plusone size="small" annotation="none"></g:plusone></div> >+ <div><a id="twitter" href="https://twitter.com/share" class="twitter-share-button" data-count="none" data-text="[% title %]" data-lang="[% lang %]">Tweet</a></div> > </div> > [% END %] > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7932
:
9624
|
9687
|
13179
|
13397
|
13400