Attachment 135047 Details for Bug 26632 – Bug 26632: (Bug 22532 follow-up) Remove random variables

[patch] Bug 26632: (Bug 22532 follow-up) Remove random variables

Bug-26632-Bug-22532-follow-up-Remove-random-variab.patch (text/plain), 1.57 KB, created by Nick Clemens (kidclamp) on 2022-05-16 19:34:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-05-16 19:34:28 UTC

Size: 1.57 KB

patch

obsolete

>From 85fd10800c2726079ca14239ce58368148e70d50 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 16 May 2022 19:32:03 +0000
>Subject: [PATCH] Bug 26632: (Bug 22532 follow-up) Remove random variables
>
>AddBiblioToBatch and AddAuthToBatch were btoh passing a random number for the
>parameter $update_counts
>
>This simply removes that value as should have been done on 22532
>
>To test:
>1 - Stage a marc file
>2 - Confirm it works befor and after patch
>---
> C4/ImportBatch.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm
>index 845caa3b58..88a15a2095 100644
>--- a/C4/ImportBatch.pm
>+++ b/C4/ImportBatch.pm
>@@ -433,13 +433,13 @@ sub BatchStageMarcRecords {
> 
>             $num_valid++;
>             if ($record_type eq 'biblio') {
>-                $import_record_id = AddBiblioToBatch($batch_id, $rec_num, $marc_record, $encoding, int(rand(99999)), 0);
>+                $import_record_id = AddBiblioToBatch($batch_id, $rec_num, $marc_record, $encoding, 0);
>                 if ($parse_items) {
>                     my @import_items_ids = AddItemsToImportBiblio($batch_id, $import_record_id, $marc_record, 0);
>                     $num_items += scalar(@import_items_ids);
>                 }
>             } elsif ($record_type eq 'auth') {
>-                $import_record_id = AddAuthToBatch($batch_id, $rec_num, $marc_record, $encoding, int(rand(99999)), 0, $marc_type);
>+                $import_record_id = AddAuthToBatch($batch_id, $rec_num, $marc_record, $encoding, 0, $marc_type);
>             }
>         }
>     }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 26632: 135047 | 135048 | 138612 | 138613 | 139242 | 139243