Bugzilla – Attachment 135674 Details for
Bug 29963
Date accessioned plugin should not automatically fill today's date on cataloguing screens
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29963: don't use set_to_today function at dateaccessioned.pl
Bug-29963-dont-use-settotoday-function-at-dateacce.patch (text/plain), 1.74 KB, created by
Peter Vashchuk
on 2022-06-03 10:02:46 UTC
(
hide
)
Description:
Bug 29963: don't use set_to_today function at dateaccessioned.pl
Filename:
MIME Type:
Creator:
Peter Vashchuk
Created:
2022-06-03 10:02:46 UTC
Size:
1.74 KB
patch
obsolete
>From c0ea743def76cb3b911b4dad204a854d1ae40f6b Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Thu, 2 Jun 2022 14:47:39 +0300 >Subject: [PATCH] Bug 29963: don't use set_to_today function at > dateaccessioned.pl > >Don't use set_to_today function that was causing inconveniences when user >was trying to edit items in batch, it would constantly set >Date Acquired field to today's date which created the need for user to >constantly manually clear the field, so that it doesn't overwrite the >original Acquired date. > >When you add item without specifying any date for Date Acquired it >automatically sets the today's date for it so this change doesn't seem >to break any logic there. > >And when you try to edit item with already set Date Acquired before >it will show the previously defined date, not disrupting anything here >as well. > >To reproduce: >1. Edit items in batch for any biblio, see that "d - Date acquired" >field is automatically set to current day's date. >2. Apply the patch >3. "d - Date acquired" should be empty after that. >4. Additionally, go to the additem.pl to edit single item and check that >it correctly shows Date acquired in that field. >--- > cataloguing/value_builder/dateaccessioned.pl | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/cataloguing/value_builder/dateaccessioned.pl b/cataloguing/value_builder/dateaccessioned.pl >index 2f027c8e9a..d1377a2bf6 100755 >--- a/cataloguing/value_builder/dateaccessioned.pl >+++ b/cataloguing/value_builder/dateaccessioned.pl >@@ -41,8 +41,6 @@ my $builder = sub { > altInputClass: "input_marceditor flatpickr-input", > dateFormat: "Y-m-d" > }); >- /* Set current date on page load */ >- set_to_today($function_name.id); > }); > > function Focus$function_name(event) { >-- >2.28.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29963
:
135581
|
135582
|
135674
|
135683
|
135684
|
135744
|
135745
|
135746
|
135755
|
136153