Attachment 135681 Details for Bug 30885 – Bug 30885: Display recall data correctly

[patch] Bug 30885: Display recall data correctly

Bug-30885-Display-recall-data-correctly.patch (text/plain), 2.85 KB, created by David Nind on 2022-06-03 14:16:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-06-03 14:16:29 UTC

Size: 2.85 KB

patch

obsolete

>From 06a8efbef47bb7488659e517cd266a21798f34b8 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Thu, 2 Jun 2022 21:23:55 +0000
>Subject: [PATCH] Bug 30885: Display recall data correctly
>
>This page does not pull the recall columns correctly.
>
>To test:
>1) Enable the UseRecalls system preference and set up your
>recalls-related circulation rules.
>2) Check out an item to Patron B.
>3) Log into the OPAC as Patron A and search for the item.
>4) Place an item-level recall on that item.
>5) Go back to the OPAC and search for the item. Confirm that when you go
>to the record detail page, it explodes and errors are shown.
>6) Apply patch and refresh page.
>7) Confirm page loads as expected.
>8) Check the Status information for the item in the Holdings table.
>Confirm it shows the recall information correctly.
>9) Check in the item and confirm the recall as waiting for Patron A.
>10) Go back to the record detail page and confirm the Status information
>for the item shows as Waiting in the Holdings table.
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 1be6ee679a..905fd07bd3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -515,10 +515,10 @@ Note that permanent location is a code, and location may be an authval.
>                         [% END %]
> 
>                         [% IF item.recalled %]
>-                            [% IF item.recall.waitingdate %]
>-                                Waiting at [% Branches.GetName( item.recall.branchcode ) | html %] since [% item.recall.waitingdate | $KohaDates %]
>+                            [% IF item.recall.waiting_date %]
>+                                Waiting at [% Branches.GetName( item.recall.pickup_library_id ) | html %] since [% item.recall.waiting_date | $KohaDates %]
>                             [% ELSE %]
>-                                Item recalled by <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% item.recall.borrowernumber | uri %]">[% item.recall.patron.firstname | html %] [% item.recall.patron.surname | html %] ([% item.recall.patron.cardnumber | html %])</a> on [% item.recall.recalldate | $KohaDates %]
>+                                Item recalled by <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% item.recall.patron_id | uri %]">[% item.recall.patron.firstname | html %] [% item.recall.patron.surname | html %] ([% item.recall.patron.cardnumber | html %])</a> on [% item.recall.created_date | $KohaDates %]
>                             [% END %]
>                         [% END %]
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30885: 135631 | 135681 | 135706