Bugzilla – Attachment 137639 Details for
Bug 31086
Do not allow hold requests with no branchcode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31086: Update existing unit tests
Bug-31086-Update-existing-unit-tests.patch (text/plain), 2.93 KB, created by
Martin Renvoize
on 2022-07-12 15:25:00 UTC
(
hide
)
Description:
Bug 31086: Update existing unit tests
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2022-07-12 15:25:00 UTC
Size:
2.93 KB
patch
obsolete
>From 2c888bfd95f39eb1fa55f8b9e543a3a670fd1edc Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 1 Jul 2022 15:30:33 +0000 >Subject: [PATCH] Bug 31086: Update existing unit tests > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Holds.t | 8 +++++--- > t/db_dependent/Reserves.t | 4 ++-- > 2 files changed, 7 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t >index 8a19f019bb..fbff12bbd1 100755 >--- a/t/db_dependent/Holds.t >+++ b/t/db_dependent/Holds.t >@@ -153,6 +153,7 @@ is( $hold->suspend_until, '2013-01-01 00:00:00', "Test ModReserve, suspend until > > ModReserve({ # call without reserve_id > rank => '3', >+ branchcode => $branch_1, > biblionumber => $biblio->biblionumber, > itemnumber => $itemnumber, > borrowernumber => $borrowernumber, >@@ -346,6 +347,7 @@ $hold = Koha::Hold->new( > borrowernumber => $borrowernumbers[0], > itemnumber => $itemnumber, > biblionumber => $biblio->biblionumber, >+ branchcode => $branch_1, > } > )->store(); > is( CanItemBeReserved( $patrons[0], $damaged_item )->{status}, >@@ -525,7 +527,7 @@ subtest 'CanItemBeReserved' => sub { > > # Biblio-level hold > AddReserve({ >- branch => $branch_1, >+ branchcode => $branch_1, > borrowernumber => $borrowernumbers[0], > biblionumber => $biblionumber_1, > }); >@@ -541,7 +543,7 @@ subtest 'CanItemBeReserved' => sub { > Koha::Holds->search({borrowernumber => $borrowernumbers[0]})->delete; > # Item-level hold > AddReserve({ >- branch => $branch_1, >+ branchcode => $branch_1, > borrowernumber => $borrowernumbers[0], > biblionumber => $biblionumber_1, > itemnumber => $item_11->itemnumber, >@@ -595,7 +597,7 @@ subtest 'CanItemBeReserved' => sub { > ); > > AddReserve({ >- branch => $branch_1, >+ branchcode => $branch_1, > borrowernumber => $borrowernumbers[0], > biblionumber => $biblionumber_2, > itemnumber => $item_21->itemnumber >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index 91ebbf3f3b..e309ecfd55 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -559,14 +559,14 @@ my $borrowernumber_tmp_2 = $bor_tmp_2->borrowernumber; > my $date_in_future = dt_from_string(); > $date_in_future = $date_in_future->add_duration(DateTime::Duration->new(days => 1)); > AddReserve({ >- branch => 'CPL', >+ branchcode => 'CPL', > borrowernumber => $borrowernumber_tmp_1, > biblionumber => $bibnum, > priority => 3, > reservation_date => output_pref($date_in_future) > }); > AddReserve({ >- branch => 'CPL', >+ branchcode => 'CPL', > borrowernumber => $borrowernumber_tmp_2, > biblionumber => $bibnum, > priority => 4, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31086
:
136983
|
136984
|
136986
|
136987
|
137026
|
137254
|
137255
|
137256
|
137257
|
137258
|
137635
|
137636
|
137637
|
137638
| 137639 |
137640
|
137641
|
137642
|
138006
|
138018
|
138051
|
144824