Bugzilla – Attachment 138612 Details for
Bug 26632
BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26632: (Bug 22532 follow-up) Remove random variables
Bug-26632-Bug-22532-follow-up-Remove-random-variab.patch (text/plain), 1.63 KB, created by
ByWater Sandboxes
on 2022-08-04 20:26:49 UTC
(
hide
)
Description:
Bug 26632: (Bug 22532 follow-up) Remove random variables
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2022-08-04 20:26:49 UTC
Size:
1.63 KB
patch
obsolete
>From 9cbe1d648ef238ae6738f5ffc432742655c3f450 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 16 May 2022 19:32:03 +0000 >Subject: [PATCH] Bug 26632: (Bug 22532 follow-up) Remove random variables > >AddBiblioToBatch and AddAuthToBatch were btoh passing a random number for the >parameter $update_counts > >This simply removes that value as should have been done on 22532 > >To test: >1 - Stage a marc file >2 - Confirm it works befor and after patch > >Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> >--- > C4/ImportBatch.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm >index 25b44d614b..71f395088b 100644 >--- a/C4/ImportBatch.pm >+++ b/C4/ImportBatch.pm >@@ -375,13 +375,13 @@ sub BatchStageMarcRecords { > > $num_valid++; > if ($record_type eq 'biblio') { >- $import_record_id = AddBiblioToBatch($batch_id, $rec_num, $marc_record, $encoding, int(rand(99999)), 0); >+ $import_record_id = AddBiblioToBatch($batch_id, $rec_num, $marc_record, $encoding, 0); > if ($parse_items) { > my @import_items_ids = AddItemsToImportBiblio($batch_id, $import_record_id, $marc_record, 0); > $num_items += scalar(@import_items_ids); > } > } elsif ($record_type eq 'auth') { >- $import_record_id = AddAuthToBatch($batch_id, $rec_num, $marc_record, $encoding, int(rand(99999)), 0, $marc_type); >+ $import_record_id = AddAuthToBatch($batch_id, $rec_num, $marc_record, $encoding, 0, $marc_type); > } > } > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26632
:
135047
|
135048
|
138612
|
138613
|
139242
|
139243