Bugzilla – Attachment 140713 Details for
Bug 30687
Unable to override hold policy if no pickup locations are available
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30687: (QA follow-up) Allow pickup location choice when overridden
Bug-30687-QA-follow-up-Allow-pickup-location-choic.patch (text/plain), 2.06 KB, created by
Nick Clemens (kidclamp)
on 2022-09-16 15:11:45 UTC
(
hide
)
Description:
Bug 30687: (QA follow-up) Allow pickup location choice when overridden
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-09-16 15:11:45 UTC
Size:
2.06 KB
patch
obsolete
>From a87afb5b6250bd533305c06c3838c9193e83b15d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 16 Sep 2022 15:07:05 +0000 >Subject: [PATCH] Bug 30687: (QA follow-up) Allow pickup location choice when > overridden > >The original test plan did not recreate behaviour for me, but I simply added: >Default checkout, hold and return policy >Hold policy: from home library >Hold pickup library match: Item hold group (with no groups defined) > >Then I couldn't place hold before, but could place hold after patch, however, >I couldn't choose a pickup location for the item level hold and the hold failed > >To test: >1 - Set rules as above >2 - Confirm you can choose a library for item specific hold >3 - Confirm all locations are marked with exclamation point >4 - Confirm hold can successfully be placed > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index eb37dbc00e..cdd4106a5a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -742,7 +742,7 @@ > [% END # /IF force_hold_level %] > </td> > <td> >- [% IF (itemloo.pickup_locations_count > 0) %] >+ [% IF (itemloo.pickup_locations_count > 0) || itemloo.override %] > <select name="item_pickup_[% itemloo.itemnumber | html %]" class="pickup_locations" style="width:100%;" > data-item-id="[% itemloo.itemnumber | html %]" > data-patron-id="[% patron.borrowernumber | html %]" >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30687
:
134625
|
137643
|
140683
|
140712
|
140713
|
143457
|
144427
|
144825
|
144896
|
148502
|
150260