Bugzilla – Attachment 148761 Details for
Bug 33322
"Please select at least one suggestion" when doing a catalog search from suggestions page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33322: Refine click handler for suggestion batch operations
Bug-33322-Refine-click-handler-for-suggestion-batc.patch (text/plain), 2.60 KB, created by
ByWater Sandboxes
on 2023-03-27 12:18:42 UTC
(
hide
)
Description:
Bug 33322: Refine click handler for suggestion batch operations
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2023-03-27 12:18:42 UTC
Size:
2.60 KB
patch
obsolete
>From 2a102bb6393599d4f470d0c0d5a2c0efd286caf5 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 23 Mar 2023 17:15:48 +0000 >Subject: [PATCH] Bug 33322: Refine click handler for suggestion batch > operations > >The handler for suggestion batch operations looks for clicks on >"button[type='submit']" which is not very specific. With the new staff >interface this ends up including the header search form. > >This patch modifies the markup of the batch operations section of >the template and makes the click handler more specific so that only the >right buttons are affected. > >To test, apply the patch and go to Suggestions. > >- In the header search form, perform a catalog search. You should be > able to click the submit button to successfully initiate the search. >- Without checking a checkbox associated with any open suggestion, test > the batch operation buttons at the bottom: > - Change status > - Change item type > - Update manager > - Delete > - Archive > All should trigger a JS alert, "Please select at least one suggestion" >- Test each batch operation with one or more suggestions selected and > confirm that the operation completes successfully. > >Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 1363134a66..2f2df3a5d6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -888,7 +888,7 @@ > <h2>Change selected suggestions</h2> > </div> > </div> >- <div class="row"> >+ <div id="suggestions_batch_ops" class="row"> > <div class="col-sm-4"> > <fieldset class="brief"> > <div id="select-reason[% loop.index | html %]"> >@@ -1416,7 +1416,7 @@ > $("#" + target).toggle(); > }); > >- $("button[type='submit']").on("click", function(e) { >+ $("button[type='submit']", "#suggestions_batch_ops").on("click", function(e) { > var submit_button = this; > var form = $(submit_button).parents("form"); > var action = $(submit_button).val(); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33322
:
148657
|
148761
|
148925
|
148926