Bugzilla – Attachment 164380 Details for
Bug 36495
Add render_resource_not_found() and render_resource_deleted() helpers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36495: Trivial tests fixes
Bug-36495-Trivial-tests-fixes.patch (text/plain), 3.42 KB, created by
Tomás Cohen Arazi
on 2024-04-03 13:11:04 UTC
(
hide
)
Description:
Bug 36495: Trivial tests fixes
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2024-04-03 13:11:04 UTC
Size:
3.42 KB
patch
obsolete
>From 12bbc70278cfd73e1d53631d0fd01e2903b8f4b2 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 3 Apr 2024 13:10:43 +0000 >Subject: [PATCH] Bug 36495: Trivial tests fixes > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/api/v1/authorities.t | 2 +- > t/db_dependent/api/v1/biblios.t | 6 +++--- > t/db_dependent/api/v1/clubs_holds.t | 2 +- > t/db_dependent/api/v1/jobs.t | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/t/db_dependent/api/v1/authorities.t b/t/db_dependent/api/v1/authorities.t >index 68e24e48e21..d0701b14159 100755 >--- a/t/db_dependent/api/v1/authorities.t >+++ b/t/db_dependent/api/v1/authorities.t >@@ -108,7 +108,7 @@ subtest 'get() tests' => sub { > $t->get_ok( "//$userid:$password@/api/v1/authorities/" . $authority->id > => { Accept => 'application/marc' } ) > ->status_is(404) >- ->json_is( '/error', 'Object not found' ); >+ ->json_is( '/error', 'Authority record not found' ); > > $schema->storage->txn_rollback; > }; >diff --git a/t/db_dependent/api/v1/biblios.t b/t/db_dependent/api/v1/biblios.t >index d6d2b4f5d9d..9f0417f05eb 100755 >--- a/t/db_dependent/api/v1/biblios.t >+++ b/t/db_dependent/api/v1/biblios.t >@@ -105,7 +105,7 @@ subtest 'get() tests' => sub { > $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber > => { Accept => 'application/marc' } ) > ->status_is(404) >- ->json_is( '/error', 'Object not found' ); >+ ->json_is( '/error', 'Bibliographic record not found' ); > > subtest 'marc-in-json encoding tests' => sub { > >@@ -408,7 +408,7 @@ subtest 'get_public() tests' => sub { > $t->get_ok( "//$userid:$password@/api/v1/public/biblios/" . $biblio->biblionumber > => { Accept => 'application/marc' } ) > ->status_is(404) >- ->json_is( '/error', 'Object not found' ); >+ ->json_is( '/error', 'Bibliographic record not found' ); > > $schema->storage->txn_rollback; > }; >@@ -568,7 +568,7 @@ subtest 'pickup_locations() tests' => sub { > . "/pickup_locations?" > . "patron_id=" . $patron->id ) > ->status_is( 404 ) >- ->json_is( '/error' => 'Biblio not found' ); >+ ->json_is( '/error' => 'Bibliographic record not found' ); > > $schema->storage->txn_rollback; > }; >diff --git a/t/db_dependent/api/v1/clubs_holds.t b/t/db_dependent/api/v1/clubs_holds.t >index 49c56e3a5f7..927e7eb5aac 100755 >--- a/t/db_dependent/api/v1/clubs_holds.t >+++ b/t/db_dependent/api/v1/clubs_holds.t >@@ -122,7 +122,7 @@ subtest 'add() tests' => sub { > biblio_id => $non_existent_biblio_id, > pickup_library_id => $non_existent_item_homebranch > } >- )->status_is(404)->json_is( '/error' => 'Biblio not found' ); >+ )->status_is(404)->json_is( '/error' => 'Bibliographic record not found' ); > > $t->post_ok( > "//$userid:$password@/api/v1/clubs/" >diff --git a/t/db_dependent/api/v1/jobs.t b/t/db_dependent/api/v1/jobs.t >index 1095d94d806..7fae9293fc5 100755 >--- a/t/db_dependent/api/v1/jobs.t >+++ b/t/db_dependent/api/v1/jobs.t >@@ -141,7 +141,7 @@ my $job_current = $builder->build_object( > $job->delete; > $t->get_ok( "//$superlibrarian_userid:$password@/api/v1/jobs/" > . $job->id )->status_is(404) >- ->json_is( '/error' => 'Object not found' ); >+ ->json_is( '/error' => 'Job not found' ); > } > > $schema->storage->txn_rollback; >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36495
:
164291
|
164297
|
164301
|
164377
|
164378
|
164380
|
164382
|
164383
|
164384
|
164971
|
164972
|
164973
|
164983
|
164984
|
164985
|
165696