Bugzilla – Attachment 166688 Details for
Bug 35862
Display patron search result on the right of the form (modal)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35862: Fix patron_search_form selection
Bug-35862-Fix-patronsearchform-selection.patch (text/plain), 1.63 KB, created by
Jonathan Druart
on 2024-05-14 12:51:09 UTC
(
hide
)
Description:
Bug 35862: Fix patron_search_form selection
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-05-14 12:51:09 UTC
Size:
1.63 KB
patch
obsolete
>From e552adbbf89ed50681b8626b39c73d9e494ee539 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 14 May 2024 14:47:33 +0200 >Subject: [PATCH] Bug 35862: Fix patron_search_form selection > >We were no longer getting a match here and so ended up with 2 forms on >the budget page (where we have two modals for patron: owner and users). > >Caught be selenium tests patrons_search.t : >Error while executing command: element not interactable: Element <a class="patron_name patron_preview" href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=511"> could not be scrolled into view > >It fixes the following UI issues: >When you open a modal, start a search, close the modal >open the other modal search: the results from the other modal were shown >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >index 6dd9d150fa5..c8dd64c1241 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >@@ -275,7 +275,7 @@ > > function get_patron_search_form(){ > let parent_block = $("#[% search_results_block_id | html %]"); >- let patron_search_form = parent_block.siblings(".patron_search_form"); >+ let patron_search_form = parent_block.parent().find(".patron_search_form"); > if ( !patron_search_form.length ) patron_search_form = $(".patron_search_form"); > return patron_search_form; > } >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35862
:
162858
|
162862
|
162959
|
166687
| 166688