Bugzilla – Attachment 17685 Details for
Bug 10111
Layout on basket summary page a bit inconsistent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10111 - Layout on basket summary page a bit inconsistent
Bug-10111---Layout-on-basket-summary-page-a-bit-in.patch (text/plain), 3.43 KB, created by
Owen Leonard
on 2013-04-25 13:39:03 UTC
(
hide
)
Description:
Bug 10111 - Layout on basket summary page a bit inconsistent
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-04-25 13:39:03 UTC
Size:
3.43 KB
patch
obsolete
>From 7f0895b9f3b9a1737096a4aa85a8ee8930786392 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 25 Apr 2013 09:34:17 -0400 >Subject: [PATCH] Bug 10111 - Layout on basket summary page a bit inconsistent >Content-Type: text/plain; charset="utf-8" > >Some details in the summary of basket information were not marked up >consistently with others on the page. This patch makes the markup >consistent for a consistent appearance. > >To test, view a basket in Acquisitions which is part of a basketgroup. >Information should be displayed consistently for baksets in both open >and closed basket groups. >--- > .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 23 +++++++++----------- > 1 file changed, 10 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 463760f..96d2dee 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -204,13 +204,14 @@ > [% IF ( closedate ) %] > <div class="yui-u"> > <form action="/cgi-bin/koha/acqui/basketgroup.pl" method="post"> >- <p> >- <label for="basketgroupid"><strong>Basket group:</strong></label> >+ <ol> >+ <li> >+ <span class="label">Basket group:</span> > [% IF basketgroup.closed %] > [% basketgroup.name %] (closed) > [% ELSE %] >- </p> >- <p> >+ </li> >+ <li> > <select id="basketgroupid" name="basketgroupid"> > <option value="new">Add new group</option> > [% FOREACH bg IN basketgroups %] >@@ -225,20 +226,16 @@ > [% END %] > [% END %] > </select> >- [% END %] >- </p> >- >- [% UNLESS basketgroup.closed %] >- <p> > <input type="hidden" id="basketno" value="[% basketno %]" name="basketno" /> > <input type="hidden" value="mod_basket" name="op" /> > <input type="hidden" name="booksellerid" value="[% booksellerid %]" /> > <input type="submit" value="Change basket group" /> >- </p> >- [% END %] >+ [% END %] >+ </li> >+ [% IF ( basketgroupdeliveryplace ) %]<li><span class="label">Basket group delivery place:</span> [% basketgroupdeliveryplace %]</li>[% END %] >+ [% IF ( basketgroupbillingplace ) %]<li><span class="label">Basket group billing place:</span> [% basketgroupbillingplace %]</li>[% END %] >+ </ol> > </form> >- [% IF ( basketgroupdeliveryplace ) %]<p>Basket group delivery place: [% basketgroupdeliveryplace %]</p>[% END %] >- [% IF ( basketgroupbillingplace ) %]<p>Basket group billing place: [% basketgroupbillingplace %]</p>[% END %] > </div> > [% END %] > </div> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10111
:
17662
|
17685
|
17688
|
17694
|
17861