Bugzilla – Attachment 17781 Details for
Bug 10097
Hide framework selection when importing staged authority records
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10097 - Hide framework selection when importing staged authority records
PASSED-QA-Bug-10097---Hide-framework-selection-whe.patch (text/plain), 3.07 KB, created by
Katrin Fischer
on 2013-04-29 05:50:44 UTC
(
hide
)
Description:
[PASSED QA] Bug 10097 - Hide framework selection when importing staged authority records
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-04-29 05:50:44 UTC
Size:
3.07 KB
patch
obsolete
>From 17375c24f83ca888e15e15fc06d5992d8127c292 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 23 Apr 2013 12:58:19 +1000 >Subject: [PATCH] [PASSED QA] Bug 10097 - Hide framework selection when > importing staged authority records > >Currently, when importing authority records using the "Manage staged >MARC records" tool, it will show the text "Add new bibliographic records >into this framework:" followed by a drop-down menu of possible frameworks. > >Since these are bibliographic frameworks and we're importing authority >records which do not use them, we have no need to show this information. > >I'm proposing just a little patch to display this info only for >bibliographic records. From my tests, everything seems to work fine >without this text and the drop-down, although I've only uploaded one >MARC21 authority record at a time. > >-- > >Test Plan: > >Before applying patch... > >1) Find yourself an authority record. I recommend downloading your >favourite author from: http://authorities.loc.gov/ >2) Stage MARC for import. Choose "Authority" as your record type. >3) Go to "Manage staged records" >4) Underneath the button "Import this batch into the catalog", you >should see the text "Add new bibliographic records into this framework:" >followed by a drop-down of the available frameworks. > >Optionally) You can also try this for bibliographic records. You'll find >the same. > >After applying the patch... > >5) Repeat steps 2 and 3. >6) Underneath the button "Import this batch into the catalog", you >should just see a table listing your MARC record(s). >7) Stage MARC for import. Choose "Bibliographic" as your record type. >8) Go to "Manage staged records". >9) You should find step 4 still to be true (i.e. the "Add new >bibliographic..." text should still be there). > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Small template change, passes all tests. >--- > .../prog/en/modules/tools/manage-marc-import.tt | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >index e0325bb..b81ffea 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >@@ -191,6 +191,7 @@ $(document).ready(function(){ > <fieldset class="action"> > <input type="submit" class="button" name="mainformsubmit" value="Import this batch into the catalog" onclick="return submitBackgroundJob(this.form);" /> > <br/> >+ [% IF ( record_type != 'auth' ) %] > Add new bibliographic records into this framework: > <select name="framework" id="frameworks"> > <option value="">Default</option> >@@ -198,6 +199,7 @@ $(document).ready(function(){ > <option value="[% framework.value %]">[% framework.label %]</option> > [% END %] > </select> >+ [% END %] > </fieldset> > </form> > <div id="jobpanel"><div id="jobstatus">Job progress: <div id="jobprogress"></div> <span id="jobprogresspercent">0</span>%</div> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10097
:
17602
|
17725
| 17781