Bugzilla – Attachment 20156 Details for
Bug 10663
Holds never block renewals
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10663: Follow-up - Revert and use CheckReserves for CanBookBeRenewed
Bug-10663-Follow-up---Revert-and-use-CheckReserves.patch (text/plain), 955 bytes, created by
Chris Cormack
on 2013-08-08 04:51:26 UTC
(
hide
)
Description:
Bug 10663: Follow-up - Revert and use CheckReserves for CanBookBeRenewed
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-08-08 04:51:26 UTC
Size:
955 bytes
patch
obsolete
>From 678d8c03a013c9c5286cbd1fd7ac9ad639c06f64 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Thu, 8 Aug 2013 01:40:17 +0200 >Subject: [PATCH] Bug 10663: Follow-up - Revert and use CheckReserves for > CanBookBeRenewed > >CheckReserves returns '' when no reserve is found, >so $resfound will always be defined and we need to >check if it's true. > >This is part of the revert. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index aee1dbd..c578213 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2486,7 +2486,7 @@ sub CanBookBeRenewed { > > my ( $resfound, $resrec, undef ) = C4::Reserves::CheckReserves( $itemnumber ); > >- if ( defined $resfound ) { >+ if ( $resfound ) { # '' when no hold was found > $renewokay = 0; > $error = "on_reserve"; > } >-- >1.8.3.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10663
:
19987
|
20129
|
20139
|
20140
|
20148
|
20149
|
20150
|
20151
|
20152
|
20153
|
20154
|
20155
|
20156
|
20362
|
20363
|
20364
|
22913