Attachment 23364 Details for Bug 11360 – Bug 11360 - Disable barcode field and submit button when a hold is found

[patch] Bug 11360 - Disable barcode field and submit button when a hold is found

Bug-11360---Disable-barcode-field-and-submit-butto.patch (text/plain), 3.70 KB, created by Kyle M Hall (khall) on 2013-12-09 20:30:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-12-09 20:30:47 UTC

Size: 3.70 KB

patch

obsolete

>From 380eeb406a3f4b749d8eec1ef04b596e41040ec6 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 9 Dec 2013 15:28:15 -0500
>Subject: [PATCH] Bug 11360 - Disable barcode field and submit button when a hold is found
>
>At the moment when scanning in returns, it can be easy to miss a hold
>trap due to the fact that the barcode and submit are still active and
>the barcode field is focused on. A librarian who is focused on scanning
>can easily scan another item and pass over the form, which is equivalent
>to clicking the "ignore" button.
>
>Test Plan:
>1) Place a hold on an item
>2) Scan that item's barcode though returns.pl
>3) Note the hold trap
>4) Scan another barcode
>5) Note you were able to bypass interacting with the trapped hold form
>6) Apply this patch
>7) Repeat steps 2-4
>8) Note you must now click one of the buttons.
>   Clicking ignore will allow you to continue scanning items as before.
>---
> .../intranet-tmpl/prog/en/modules/circ/returns.tt  |   20 ++++++++++++++------
> 1 files changed, 14 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index fb30311..d435d9f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -299,7 +299,7 @@ $(document).ready(function () {
>                 <input type="submit" class="approve" value="Confirm hold" />
>                 <input type="submit" value="Print slip and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&amp;biblionumber=[% itembiblionumber %]&amp;op=slip'); this.form.submit();" />
>             [% END %]
>-                <input type="submit" class="deny" value="Ignore" onclick="$('.dialog:visible').hide('slow'); $('#barcode').focus(); return false;" />
>+                <input type="submit" class="deny" value="Ignore" onclick="$('.dialog:visible').hide('slow'); $('#submit').removeAttr('disabled'); $('#barcode').removeAttr('disabled').focus(); return false;" />
>             [% FOREACH inputloo IN inputloop %]
> 	<input type="hidden" name="ri-[% inputloo.counter %]" value="[% inputloo.barcode %]" />
> 	<input type="hidden" name="dd-[% inputloo.counter %]" value="[% inputloo.duedate %]" />
>@@ -384,14 +384,22 @@ $(document).ready(function () {
>             <fieldset>
> 	<legend>Check In</legend>
>             <label for="barcode">Enter item barcode: </label>
>-			[% IF ( exemptfine ) %]
>-			<input name="barcode" id="barcode" size="14" class="focus alert"/>
>+            [% IF found %]
>+                <input name="barcode" id="barcode" size="14" disabled="disabled"/>
>+            [% ELSIF ( exemptfine ) %]
>+                <input name="barcode" id="barcode" size="14" class="focus alert"/>
> 			[% ELSIF ( dropboxmode ) %]
>-			<input name="barcode" id="barcode" size="14" class="focus alert"/>
>+                <input name="barcode" id="barcode" size="14" class="focus alert"/>
> 			[% ELSE %]
>-			<input name="barcode" id="barcode" size="14" class="focus"/>
>+                <input name="barcode" id="barcode" size="14" class="focus"/>
> 			[% END %]
>-            <input type="submit" class="submit" value="Submit" />
>+
>+            [% UNLESS found %]
>+                <input id="submit" type="submit" class="submit" value="Submit" />
>+            [% ELSE %]
>+                <input id="submit" type="submit" class="submit" value="Submit" disabled="disabled"/>
>+            [% END %]
>+
>             [% FOREACH inputloo IN inputloop %]
>                 <input type="hidden" name="ri-[% inputloo.counter %]" value="[% inputloo.barcode %]" />
>                 <input type="hidden" name="dd-[% inputloo.counter %]" value="[% inputloo.duedate %]" />
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11360: 23364 | 23367 | 23511 | 44967 | 45038 | 45122 | 47594 | 48749 | 48790 | 50343 | 51964 | 53205 | 53531 | 53685 | 53686