Attachment 24002 Details for Bug 11491 – Bug 11491 - Old License and strict, warnings

[patch] Bug 11491 - Old License and strict, warnings

Bug-11491---Old-License-and-strict-warnings.patch (text/plain), 2.66 KB, created by Mark Tompsett on 2014-01-07 23:39:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2014-01-07 23:39:23 UTC

Size: 2.66 KB

patch

obsolete

>From 2287f6cffde10d7d094ae20eeb7922999ef02516 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Tue, 7 Jan 2014 14:43:31 -0500
>Subject: [PATCH] Bug 11491 - Old License and strict, warnings
>
>Replaced License text with latest one from
>    http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence
>and tweaked copyright lines accordingly.
>
>Also changed use strict and use warnings into use Modern::Perl
>as per PERL2 from the coding guidelines.
>
>TEST PLAN
>---------
>1) less ~/kohaclone/opac/svc/report
>   - The license does not reflect the current license
>   - This will have use strict and use warnings
>2) Apply patch
>   - The license should be corrected
>3) It should still run
>     https://.../cgi-bin/koha/svc/report?id=##
>     https://.../cgi-bin/koha/svc/report?id=##&header=blah
>   Where ## reflects a public report available.
>---
> opac/svc/report |   29 ++++++++++++++---------------
> 1 file changed, 14 insertions(+), 15 deletions(-)
>
>diff --git a/opac/svc/report b/opac/svc/report
>index 71062d5..ec64c1a 100755
>--- a/opac/svc/report
>+++ b/opac/svc/report
>@@ -1,25 +1,24 @@
> #!/usr/bin/perl
> 
>-# Copyright 2011 Chris Cormack <chris@bigballofwax.co.nz>
>-#
> # This file is part of Koha.
> #
>-# Koha is free software; you can redistribute it and/or modify it under the
>-# terms of the GNU General Public License as published by the Free Software
>-# Foundation; either version 2 of the License, or (at your option) any later
>-# version.
>+# Copyright (C) 2011  Chris Cormack <chris@bigballofwax.co.nz>
>+# Copyright (C) 2013  Mark Tompsett
> #
>-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
>-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
>-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
> #
>-# You should have received a copy of the GNU General Public License along
>-# with Koha; if not, write to the Free Software Foundation, Inc.,
>-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>-
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
>-use strict;
>-use warnings;
>+use Modern::Perl;
> 
> use C4::Reports::Guided;
> use JSON;
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 11491: 24000 | 24001 | 24002 | 24909 | 24910 | 24911 | 24912 | 24913 | 24914 | 24915 | 24916 | 24917 | 24923 | 24924 | 24960 | 24961