Bugzilla – Attachment 25103 Details for
Bug 11702
Can't specify date for automatic resumption of suspended hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11702 - Can't specify date for automatic resumption of suspended hold
Bug-11702---Cant-specify-date-for-automatic-resump.patch (text/plain), 2.15 KB, created by
Owen Leonard
on 2014-02-06 17:30:56 UTC
(
hide
)
Description:
Bug 11702 - Can't specify date for automatic resumption of suspended hold
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-02-06 17:30:56 UTC
Size:
2.15 KB
patch
obsolete
>From 30cecad8b4d476c4daab686045345911aa62e679 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 6 Feb 2014 12:20:31 -0500 >Subject: [PATCH] Bug 11702 - Can't specify date for automatic resumption of > suspended hold >Content-Type: text/plain; charset="utf-8" > >When suspending an individual hold in the OPAC or staff client the date >of resumption is saved as '000-00-00' no matter what dateformat setting >you use. This is not true of performing a suspend-all action. > >This patch changes the date handling in C4::Reserves::ToggleSuspend to >match that in C4::Reserves::SuspendAll. > >To test in the OPAC: > >1. Turn on RequestOnOpac, AutoResumeSuspendedHolds, and > SuspendHoldsOpac. >2. Log in to the OPAC and place a hold. >3. View the list of your existing holds (opac-user.pl). >4. Choose an individual hold to suspend, specify a suspend-until date, > and submit. >5. When the page reloads the suspension should be saved with the correct > resumption date. > >Test using all dateformat system preference options. Also test >suspensions without resumption dates. > >To test in the staff client: > >1. Turn on AutoResumeSuspendedHolds and SuspendHoldsIntranet. >2. Place a hold for a patron, or find an existing hold. >3. View the hold details page for that hold > (/cgi-bin/koha/reserve/request.pl?biblionumber=XX). >4. Specify a suspend-until date for the hold and submit. >5. When the page reloads the hold should say "Unsuspend on" and show the > correct resumption date. > >Test using all dateformat system preference options. Also test >suspensions without resumption dates. >--- > C4/Reserves.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 8fe0fd0..f9e45ce 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -1537,7 +1537,7 @@ be cleared when it is unsuspended. > sub ToggleSuspend { > my ( $reserve_id, $suspend_until ) = @_; > >- $suspend_until = output_pref({ dt => dt_from_string( $suspend_until ), dateformat => 'iso' }) if ( $suspend_until ); >+ $suspend_until = C4::Dates->new( $suspend_until )->output("iso") if ( defined( $suspend_until ) ); > > my $do_until = ( $suspend_until ) ? '?' : 'NULL'; > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11702
: 25103