Bugzilla – Attachment 2533 Details for
Bug 5143
Subtitles not showing on view_holdsqueue.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Potential fix
0001-Potential-fix-for-Bug-5143.patch (text/plain), 3.65 KB, created by
Chris Cormack
on 2010-08-17 21:57:38 UTC
(
hide
)
Description:
Potential fix
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2010-08-17 21:57:38 UTC
Size:
3.65 KB
patch
obsolete
>From b10f0d503f12719618dae62a135b935399bc25d5 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Wed, 18 Aug 2010 09:53:23 +1200 >Subject: [PATCH] Potential fix for Bug 5143 > >You will need to set up mappings at /cgi-bin/koha/admin/fieldmapping.pl >for >subtitle, parts, numbers (like that) > >Squashed commit of the following: > >commit 11df1c363af3fe660e25fb1b18885d205137adb4 >Author: Chris Cormack <chrisc@catalyst.net.nz> >Date: Wed Aug 18 09:52:31 2010 +1200 > > Final fix for this bug 5143 > >commit efbb69d898c07332404d6ca906f801ad7ae89707 >Author: Chris Cormack <chrisc@catalyst.net.nz> >Date: Wed Aug 18 09:40:09 2010 +1200 > > Typo fix > >commit 0b9423ab3910138e561d73e63190a2a51c7bb603 >Author: Chris Cormack <chrisc@catalyst.net.nz> >Date: Wed Aug 18 09:36:47 2010 +1200 > > Bug 5143, adding subtile, parts and numbers to the holdsqueue report >--- > circ/view_holdsqueue.pl | 8 +++++++- > .../prog/en/modules/cataloguing/addbiblio.tmpl | 3 +++ > .../prog/en/modules/circ/view_holdsqueue.tmpl | 3 ++- > 3 files changed, 12 insertions(+), 2 deletions(-) > >diff --git a/circ/view_holdsqueue.pl b/circ/view_holdsqueue.pl >index 668bdd1..3023cdf 100755 >--- a/circ/view_holdsqueue.pl >+++ b/circ/view_holdsqueue.pl >@@ -96,7 +96,13 @@ sub GetHoldsQueueItems { > $sth->execute(@bind_params); > my $items = []; > while ( my $row = $sth->fetchrow_hashref ){ >- $row->{reservedate} = format_date($row->{reservedate}); >+ $row->{reservedate} = format_date($row->{reservedate}); >+ my $record = GetMarcBiblio($row->{biblionumber}); >+ if ($record){ >+ $row->{subtitle} = GetRecordValue('subtitle',$record,'')->[0]->{subfield}; >+ $row->{parts} = GetRecordValue('parts',$record,'')->[0]->{subfield}; >+ $row->{numbers} = GetRecordValue('numbers',$record,'')->[0]->{subfield}; >+ } > push @$items, $row; > } > return $items; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl >index e722afb..520ab14 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl >@@ -42,11 +42,14 @@ function confirmnotdup(){ > * > */ > function Check(dest){ >+ alert("WHAT!!"); > var StrAlert = AreMandatoriesNotOk(); >+ alert("didnt get here"); > if( ! StrAlert ){ > document.f.submit(); > return true; > } else { >+ alert("test"); > alert(StrAlert); > return false; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tmpl >index 52ddd85..b5a1997 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tmpl >@@ -45,7 +45,8 @@ > </thead> > <tbody><!-- TMPL_LOOP NAME="itemsloop"--> > <tr> >- <td><p><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber"-->"><strong><!-- TMPL_VAR NAME="title" escape="html"--></strong></a></p> >+ <td><p><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber"-->"><strong><!-- TMPL_VAR NAME="title" escape="html"--></strong></a></p> >+ <p><!-- TMPL_VAR NAME="subtitle" ESCAPE="HTML"--> <!-- TMPL_VAR NAME="parts" --> <!-- TMPL_VAR NAME="numbers" --></p> > <p><strong><!-- TMPL_VAR NAME="author" --></strong> > <!-- TMPL_IF name="publishercode" --><!-- TMPL_VAR name="publishercode" --><!-- /TMPL_IF --> > <!-- TMPL_IF name="publicationyear" -->, <!-- TMPL_VAR name="publicationyear" --> >-- >1.7.0.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5143
:
2533
|
2551
|
2552
|
2843
|
2846
|
2847