Bugzilla – Attachment 27667 Details for
Bug 766
Omnibus: Use of CGI::scrolling_list prevents customization in template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 766: Use the method plugin to generate sort dropdown list - memberentry
PASSED-QA-Bug-766-Use-the-method-plugin-to-generat.patch (text/plain), 3.03 KB, created by
Katrin Fischer
on 2014-04-26 21:15:34 UTC
(
hide
)
Description:
[PASSED QA] Bug 766: Use the method plugin to generate sort dropdown list - memberentry
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-04-26 21:15:34 UTC
Size:
3.03 KB
patch
obsolete
>From 43cf39ebf58009d00a203c7d9be80ef9caa14e48 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 6 Mar 2014 17:08:37 +0100 >Subject: [PATCH] [PASSED QA] Bug 766: Use the method plugin to generate sort > dropdown list - memberentry > >Now we can use the method plugin from the memberentry form. > >Test plan: >1/ Create a patron and verify sort1 and sort2 dropdown list are correctly >generated. >2/ Select values. >3/ Save. >4/ Edit the patron and verify the selected values are displayed. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Works as described. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > .../prog/en/modules/members/memberentrygen.tt | 17 +++++------------ > members/memberentry.pl | 3 +-- > 2 files changed, 6 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 694432e..c4d0c6a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1,3 +1,4 @@ >+[% USE AuthorisedValues %] > [% IF ( opduplicate ) %][% SET focusAction = "clearDupe" %][% END %] > [% USE KohaDates %] > [% INCLUDE 'doc-head-open.inc' %] >@@ -958,12 +959,8 @@ > <label for="sort1"> > [% END %] > Sort 1: </label> >- [% IF ( CGIsort1 ) %] >- [% CGIsort1 %] >- [% ELSE %] >- <input type="text" id="sort1" name="sort1" size="20" value="[% sort1 %]" class="[% focusAction %]" /> >- [% IF ( mandatorysort1 ) %]<span class="required">Required</span>[% END %] >- [% END %] >+ [% AuthorisedValues.BuildDropbox("sort1", "Bsort1", sort1, { class => focusAction, size => 20 } ) %] >+ [% IF ( mandatorysort1 ) %]<span class="required">Required</span>[% END %] > </li> > [% END %] > [% UNLESS nosort2 %] >@@ -974,12 +971,8 @@ > <label for="sort2"> > [% END %] > Sort 2: </label> >- [% IF ( CGIsort2 ) %] >- [% CGIsort2 %] >- [% ELSE %] >- <input type="text" id="sort2" name="sort2" size="20" value="[% sort2 %]" class="[% focusAction %]" /> >- [% IF ( mandatorysort2 ) %]<span class="required">Required</span>[% END %] >- [% END %] >+ [% AuthorisedValues.BuildDropbox("sort2", "Bsort2", sort2, { class => focusAction, size => 20 } ) %] >+ [% IF ( mandatorysort2 ) %]<span class="required">Required</span>[% END %] > </li> > [% END %] > </ol> >diff --git a/members/memberentry.pl b/members/memberentry.pl >index ff92447..3b042e3 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -630,9 +630,8 @@ $template->param( sort1 => $data{'sort1'}); # shouldn't this be in an "else" st > $CGIsort = buildCGIsort("Bsort2","sort2",$data{'sort2'}); > if ($CGIsort) { > $template->param(CGIsort2 => $CGIsort); >-} else { >- $template->param( sort2 => $data{'sort2'}); > } >+$template->param( sort2 => $data{'sort2'}); > > if ($nok) { > foreach my $error (@errors) { >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 766
:
18538
|
18550
|
18664
|
25904
|
25905
|
25906
|
25907
|
26401
|
27010
|
27011
|
27012
|
27013
|
27014
|
27044
|
27045
|
27046
|
27047
|
27048
|
27396
|
27400
|
27441
|
27442
|
27443
|
27444
|
27445
|
27446
|
27447
|
27448
|
27479
|
27495
|
27665
|
27666
|
27667
|
27668
|
27669
|
27670
|
27671
|
29870
|
29871
|
29872
|
29877
|
30404
|
30405
|
30406
|
30428
|
30430
|
30432
|
30510
|
30511
|
30512