Bugzilla – Attachment 28910 Details for
Bug 12398
CAS authentication not working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
signed patch
0001-Bug-12398-Fix-CAS-authentication-validation.patch (text/plain), 1.41 KB, created by
Matthias Meusburger
on 2014-06-17 14:28:06 UTC
(
hide
)
Description:
signed patch
Filename:
MIME Type:
Creator:
Matthias Meusburger
Created:
2014-06-17 14:28:06 UTC
Size:
1.41 KB
patch
obsolete
>From 94ab9c3b41f155ef93fedc07c66861bc2b55c905 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Tue, 10 Jun 2014 12:47:37 +0200 >Subject: [PATCH] Bug 12398: Fix CAS authentication validation > >CGI::url_param() also returns deleted parameters so we have to check >with CGI::param() too. > >Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> >--- > C4/Auth_with_cas.pm | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/C4/Auth_with_cas.pm b/C4/Auth_with_cas.pm >index 69e510f..17e43e4 100644 >--- a/C4/Auth_with_cas.pm >+++ b/C4/Auth_with_cas.pm >@@ -203,9 +203,13 @@ sub _url_with_get_params { > my $uri_base_part = C4::Context->preference('OPACBaseURL') . $query->script_name(); > my $uri_params_part = ''; > foreach ( $query->url_param() ) { >- $uri_params_part .= '&' if $uri_params_part; >- $uri_params_part .= $_ . '='; >- $uri_params_part .= URI::Escape::uri_escape( $query->url_param($_) ); >+ # url_param() always returns parameters that were deleted by delete() >+ # This additional check ensure that parameter was not deleted. >+ if ($query->param($_)) { >+ $uri_params_part .= '&' if $uri_params_part; >+ $uri_params_part .= $_ . '='; >+ $uri_params_part .= URI::Escape::uri_escape( $query->param($_) ); >+ } > } > $uri_base_part .= '?' if $uri_params_part; > >-- >1.8.3.2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12398
:
28756
|
28910
|
30048
|
30332
|
30333
|
30334
|
30378
|
30442
|
30443
|
30454