Bugzilla – Attachment 30023 Details for
Bug 8446
Shibboleth authentication
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
BUG8446, Follow up: Implimented single sign out
BUG8446-Follow-up-Implimented-single-sign-out.patch (text/plain), 3.33 KB, created by
Martin Renvoize
on 2014-07-24 10:58:43 UTC
(
hide
)
Description:
BUG8446, Follow up: Implimented single sign out
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2014-07-24 10:58:43 UTC
Size:
3.33 KB
patch
obsolete
>From a0b5a59e5192b567eeefe83e41cd50f2cc2d1a5e Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 24 Jul 2014 10:45:27 +0000 >Subject: [PATCH] BUG8446, Follow up: Implimented single sign out > >- This followup rebases the code against 3.16+ which managed to break > some of the original logic. >- As a side effect of the rebasing, we've also implimented the single > sign out element. Upon logout, koha will request that the shibboleth > session is destroyed, and then clear the local koha session upon > return to koha. Due to the nature of shibboleth however, you will > only truly be signed out of the IdP if they properly support Single > Sign Out (which many do not). As a consequence, although you may > appear to be logged out in koha, you might find that upon clicking > 'login' the IdP does NOT request your login details again, but instead > logs you silently back into your koha session. This is NOT a koha bug, > but a shibboleth implimentation issue that is well known. >--- > C4/Auth.pm | 4 ++-- > C4/Context.pm | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index e72c3de..16a628a 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -723,7 +723,7 @@ sub checkauth { > $session->param('surname'), $session->param('branch'), > $session->param('branchname'), $session->param('flags'), > $session->param('emailaddress'), $session->param('branchprinter'), >- $session->param('persona') >+ $session->param('persona'), $session->param('shibboleth') > ); > C4::Context::set_shelves_userenv('bar',$session->param('barshelves')); > C4::Context::set_shelves_userenv('pub',$session->param('pubshelves')); >@@ -735,7 +735,7 @@ sub checkauth { > $sessiontype = $session->param('sessiontype') || ''; > } > if ( ( $query->param('koha_login_context') && ($q_userid ne $s_userid) ) >- || ( $cas && $query->param('ticket') ) ) { >+ || ( $cas && $query->param('ticket') ) || ( $shib && $shib_login && !$logout ) ) { > #if a user enters an id ne to the id in the current session, we need to log them in... > #first we need to clear the anonymous session... > $debug and warn "query id = $q_userid but session id = $s_userid"; >diff --git a/C4/Context.pm b/C4/Context.pm >index 9a7b75d..8919251 100644 >--- a/C4/Context.pm >+++ b/C4/Context.pm >@@ -1112,7 +1112,7 @@ set_userenv is called in Auth.pm > > #' > sub set_userenv { >- my ($usernum, $userid, $usercnum, $userfirstname, $usersurname, $userbranch, $branchname, $userflags, $emailaddress, $branchprinter, $persona)= @_; >+ my ($usernum, $userid, $usercnum, $userfirstname, $usersurname, $userbranch, $branchname, $userflags, $emailaddress, $branchprinter, $persona, $shibboleth)= @_; > my $var=$context->{"activeuser"} || ''; > my $cell = { > "number" => $usernum, >@@ -1127,6 +1127,7 @@ sub set_userenv { > "emailaddress" => $emailaddress, > "branchprinter" => $branchprinter, > "persona" => $persona, >+ "shibboleth" => $shibboleth, > }; > $context->{userenv}->{$var} = $cell; > return $cell; >@@ -1300,4 +1301,3 @@ Andrew Arensburger <arensb at ooblick dot com> > > Joshua Ferraro <jmf at liblime dot com> > >-=cut >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8446
:
10841
|
22098
|
22107
|
22860
|
23224
|
23225
|
23226
|
25765
|
25766
|
26176
|
26177
|
26178
|
26187
|
26749
|
26750
|
26751
|
26752
|
26760
|
26761
|
26762
|
28892
|
28893
|
28894
|
28895
|
28896
|
28897
|
28898
|
28899
|
28900
|
28901
|
28902
|
28903
|
30017
|
30018
|
30019
|
30020
|
30021
|
30022
|
30023
|
30030
|
30031
|
30033
|
30283
|
30284
|
30285
|
30286
|
30335
|
30353
|
30354
|
30355
|
30356
|
30384
|
30594
|
30604
|
30605
|
30616
|
30617
|
30618
|
30619
|
30620
|
30621
|
30684
|
31407
|
31408
|
31836
|
31905
|
31906
|
31907
|
32125
|
32158
|
32162
|
32163
|
32164
|
32165
|
32166
|
32167
|
32168
|
32169
|
32170
|
32365
|
32366
|
32367
|
32368
|
32369
|
32370
|
32371
|
32372
|
32373
|
32374
|
32426
|
32427