Bugzilla – Attachment 30924 Details for
Bug 7817
Items Permanent location (shelving location) is set to NULL when item is edited
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7817: [QA FOLLOW-UP FOR ORIGINAL] QA Follow-up for original patch
Bug-7817-Follow-up-for-original-patch.patch (text/plain), 2.13 KB, created by
Marcel de Rooy
on 2014-08-18 11:29:26 UTC
(
hide
)
Description:
Bug 7817: [QA FOLLOW-UP FOR ORIGINAL] QA Follow-up for original patch
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2014-08-18 11:29:26 UTC
Size:
2.13 KB
patch
obsolete
>From ba8ce836af014ea6310d6baed1743b5f75b1d615 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 18 Aug 2014 13:25:48 +0200 >Subject: [PATCH] Bug 7817: Follow-up for original patch >Content-Type: text/plain; charset=utf-8 > >This patch removes the commented line for permanent_location. >It adds a more general comment. >It also adjusts the exists check on permanent_location. >Furthermore, it removes the line for paidfor too. Also an internal field >that was being cleared when editing items (same logic). > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Items.pm | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index f5ffada..901be2c 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -443,6 +443,9 @@ Returns item record > =cut > > my %default_values_for_mod_from_marc = ( >+# DO NOT include (internal) item fields here. >+# Only fields that are related to the MARC structure used in additem.pl >+# So please do not add fields like: permanent_location, paidfor, timestamp, etc. > barcode => undef, > booksellerid => undef, > ccode => undef, >@@ -459,10 +462,8 @@ my %default_values_for_mod_from_marc = ( > itemnotes => undef, > itype => undef, > location => undef, >-# permanent_location => undef, # "undef" counts as "exists" which disrupts proper handling of location and permanent_location in _do_column_fixes_for_mod() > materials => undef, > notforloan => 0, >- paidfor => undef, > price => undef, > replacementprice => undef, > replacementpricedate => undef, >@@ -2025,7 +2026,7 @@ sub _do_column_fixes_for_mod { > (not defined $item->{'withdrawn'} or $item->{'withdrawn'} eq '')) { > $item->{'withdrawn'} = 0; > } >- if (exists $item->{'location'} && !exists $item->{'permanent_location'}) { >+ if (exists $item->{'location'} && !$item->{'permanent_location'}) { > $item->{'permanent_location'} = $item->{'location'}; > } > if (exists $item->{'timestamp'}) { >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7817
:
28949
|
28970
|
28971
|
29093
|
30350
|
30923
|
30924
|
31133
|
31134
|
31464