Bugzilla – Attachment 32568 Details for
Bug 13114
Disabled Shibboleth authentication spams logs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13114: Prevent Shibboleth Patches from spamming logs
PASSED-QA-Bug-13114-Prevent-Shibboleth-Patches-fro.patch (text/plain), 1.46 KB, created by
Katrin Fischer
on 2014-10-21 22:02:40 UTC
(
hide
)
Description:
[PASSED QA] Bug 13114: Prevent Shibboleth Patches from spamming logs
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-10-21 22:02:40 UTC
Size:
1.46 KB
patch
obsolete
>From c7f28c0753b282b26f98b28c4aa9fad99f9a30c7 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 20 Oct 2014 13:04:45 +0000 >Subject: [PATCH] [PASSED QA] Bug 13114: Prevent Shibboleth Patches from > spamming logs > >- The shibboleth patch introduced an undefined message into the error > logs, when shiboleth is disabled. > >Testplan > >1. Ensure shibboleth is disabled. >2. Refresh any opac page >3. See 'Use of uninitialized value $ENV{"REMOTE_USER"} in string ne at >/home/koha/kohaclone/C4/Auth.pm line 711.' popup in the opac-error.log >4. Apply patch >5. Refresh opac page >6. Error should no longer appear > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as described. >--- > C4/Auth.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 7dfe3d2..bb2f308 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -708,7 +708,7 @@ sub checkauth { > # Finally, after those tests, we can assume (although if it would be better with > # a syspref) that if we get a REMOTE_USER, that's from basic authentication, > # and we can affect it to $userid. >- if ( !$shib and $ENV{'REMOTE_USER'} ne '' and $userid = $ENV{'REMOTE_USER'} ) { >+ if ( !$shib and defined($ENV{'REMOTE_USER'}) and $ENV{'REMOTE_USER'} ne '' and $userid = $ENV{'REMOTE_USER'} ) { > > # Using Basic Authentication, no cookies required > $cookie = $query->cookie( >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13114
:
32531
|
32533
| 32568