Bugzilla – Attachment 32742 Details for
Bug 13099
"Item hasn't been transferred yet" shows pickup branch rather than holding branch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13099 - "Item hasn't been transferred yet" shows pickup branch rather than holding branch
PASSED-QA-Bug-13099---Item-hasnt-been-transferred-.patch (text/plain), 1.51 KB, created by
Katrin Fischer
on 2014-10-25 19:25:54 UTC
(
hide
)
Description:
[PASSED QA] Bug 13099 - "Item hasn't been transferred yet" shows pickup branch rather than holding branch
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-10-25 19:25:54 UTC
Size:
1.51 KB
patch
obsolete
>From 1c10b57ab52223408144970df8a4c1d9eb757b82 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 16 Oct 2014 10:29:11 -0400 >Subject: [PATCH] [PASSED QA] Bug 13099 - "Item hasn't been transferred yet" > shows pickup branch rather than holding branch > >The "Item hasn't been transferred yet" message on circulation.pl and >moremember.pl in the holds table shows the pickup branch rather than >holding branch. > >Test Plan: >1) Place an item on hold for a patron >2) Check the item in to set the hold to waiting >3) Place an item level hold for another patron, > make the pickup location be a different library >4) Load the holds tab on the patron details page for the second patron >5) Note it says "Item hasn't been transferred yet from <Pickup Library>" >6) Apply this patch >7) Repeat step 4 >8) Note the library listed is now the holding library > >Signed-off-by: Paola Rossi <paola.rossi@cineca.it> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as described and passes tests and QA script. >--- > svc/holds | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/svc/holds b/svc/holds >index 3ff704f..43bcf2a 100755 >--- a/svc/holds >+++ b/svc/holds >@@ -128,7 +128,7 @@ while ( my $h = $holds_rs->next() ) { > $h->branchcode()->branchcode() ) > { > $hold->{not_transferred} = 1; >- $hold->{not_transferred_by} = $h->branchcode()->branchname(); >+ $hold->{not_transferred_by} = $h->item()->holdingbranch()->branchname(); > } > } > >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13099
:
32428
|
32555
| 32742