Attachment 33034 Details for Bug 10860 – Bug 10860: Follow-up - staff reading record

[patch] Bug 10860: Follow-up - staff reading record

Bug-10860-Follow-up---staff-reading-record.patch (text/plain), 2.35 KB, created by Kyle M Hall (khall) on 2014-10-31 10:22:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-10-31 10:22:55 UTC

Size: 2.35 KB

patch

obsolete

>From 0c1a6775274c2fdc5f298b500b6420fdfd32f967 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Thu, 30 Oct 2014 00:10:00 +0100
>Subject: [PATCH] Bug 10860: Follow-up - staff reading record
>
>- capitalization fix "Checked out"
>- display new tabs only when feature is activated
>- fixes a qa script complaint about POD in Items.pm
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Items.pm                                        |    5 +----
> .../prog/en/modules/members/readingrec.tt          |    7 +++++--
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index a8d75f7..f8c7d58 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -2571,10 +2571,7 @@ sub GetAnalyticsCount {
> 
> =head2 GetItemHolds
> 
>-=over 4
>-$holds = &GetItemHolds($biblionumber, $itemnumber);
>-
>-=back
>+  $holds = &GetItemHolds($biblionumber, $itemnumber);
> 
> This function return the count of holds with $biblionumber and $itemnumber
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
>index 53e7373..c8f9238 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
>@@ -1,4 +1,5 @@
> [% USE KohaDates %]
>+[% USE Koha %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Circulation History for [% INCLUDE 'patron-title.inc' %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -55,11 +56,13 @@
> 
> 
> <div id="tabs" class="toptabs">
>+  [% IF Koha.Preference('On-site checkouts') %]
>   <ul>
>     <li><a href="#readingrec" id="tab_all">All</a></li>
>     <li><a href="#readingrec" id="tab_checkout">Checkouts</a></li>
>-    <li><a href="#readingrec" id="tab_onsite_checkout">On-site checkout</a></li>
>+    <li><a href="#readingrec" id="tab_onsite_checkout">On-site checkouts</a></li>
>   </ul>
>+  [% END %]
>   <div id="readingrec" style="overflow:hidden">
>     <table id="table_readingrec">
>       <thead>
>@@ -117,7 +120,7 @@
>             [% IF  issue.returndate %]
>               <span title="[% issue.returndate %]">[% issue.returndate | $KohaDates %]</span>
>             [% ELSE %]
>-              <span title="Checked Out"><small>Checked Out</small></span>
>+              <span title="Checked out"><small>Checked out</small></span>
>             [% END %]
>           </td>
>         </tr>
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 10860: 20959 | 20960 | 20961 | 21195 | 21642 | 22461 | 26089 | 26114 | 26123 | 26185 | 26191 | 26192 | 31388 | 31507 | 31548 | 31664 | 31665 | 32213 | 32214 | 32216 | 32223 | 32579 | 32580 | 32581 | 32954 | 32979 | 32980 | 32981 | 32982 | 32983 | 32984 | 32997 | 32998 | 33031 | 33032 | 33033 | 33034 | 33035 | 33036 | 33037 | 33105 | 33106 | 33107 | 33108 | 33109 | 33110 | 33111 | 33163 | 33165