Attachment 39198 Details for Bug 14200 – [SIGNED-OFF] Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in some cases

[patch] [SIGNED-OFF] Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in some cases

SIGNED-OFF-Bug-14200---GetNormalizedISBN-failing-t.patch (text/plain), 1.28 KB, created by Kyle M Hall (khall) on 2015-05-14 17:44:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-05-14 17:44:41 UTC

Size: 1.28 KB

patch

obsolete

>From 4ce29aadc35ae76dbc0b7559183517e5bceecc73 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 14 May 2015 06:20:00 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in some cases
>
>For some reason the regular expression used to split the multiple ISBN
>fields can fail which keeps Business::ISBN from being able to parse out
>and return a valid isbn. Using split() instead of the regex fixes the
>issue.
>
>Test Plan:
>1) Apply the unit test patch first
>2) prove t/Koha.t
>3) Note the failures
>4) Apply the second patch
>5) prove t/Koha.t
>6) Note all tests pass
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Karen Bryant <kbryant@ccpl-fl.net>
>---
> C4/Koha.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Koha.pm b/C4/Koha.pm
>index cb0ed5a..4f54a3b 100644
>--- a/C4/Koha.pm
>+++ b/C4/Koha.pm
>@@ -1487,7 +1487,7 @@ sub GetNormalizedISBN {
>     if ($isbn) {
>         # Koha attempts to store multiple ISBNs in biblioitems.isbn, separated by " | "
>         # anything after " | " should be removed, along with the delimiter
>-        $isbn =~ s/(.*)( \| )(.*)/$1/;
>+        ($isbn) = split(/\|/, $isbn );
>         return _isbn_cleanup($isbn);
>     }
>     return unless $record;
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 14200: 39178 | 39179 | 39197 | 39198 | 39296 | 39297