Bugzilla – Attachment 41381 Details for
Bug 13663
offline circ permission issue
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13663: (followup) fixes tab char QA test fails
Bug-13663-followup-fixes-tab-char-QA-test-fails.patch (text/plain), 2.91 KB, created by
Jonathan Druart
on 2015-08-05 12:29:49 UTC
(
hide
)
Description:
Bug 13663: (followup) fixes tab char QA test fails
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-08-05 12:29:49 UTC
Size:
2.91 KB
patch
obsolete
>From 388e886f8b156e65d2b5eb8ab2f6c4fdb89232db Mon Sep 17 00:00:00 2001 >From: Indranil Das Gupta <indradg@gmail.com> >Date: Sun, 14 Jun 2015 14:52:04 +0530 >Subject: [PATCH] Bug 13663: (followup) fixes tab char QA test fails > >Fixes the tab char qa test suite fails in the following files: > >1/ tools/upload-file-progress.pl >2/ tools/upload-file.pl > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Amended patch: tidy whitespaces >--- > tools/upload-file-progress.pl | 14 +++++++------- > tools/upload-file.pl | 16 ++++++++-------- > 2 files changed, 15 insertions(+), 15 deletions(-) > >diff --git a/tools/upload-file-progress.pl b/tools/upload-file-progress.pl >index 3f7d2cd..91af827 100755 >--- a/tools/upload-file-progress.pl >+++ b/tools/upload-file-progress.pl >@@ -31,9 +31,9 @@ use CGI::Cookie; # need to check cookies before > # having CGI parse the POST request > > my $flags_required = [ >- {circulate => 'circulate_remaining_permissions'}, >- {tools => 'stage_marc_import'}, >- {tools => 'upload_local_cover_images'} >+ {circulate => 'circulate_remaining_permissions'}, >+ {tools => 'stage_marc_import'}, >+ {tools => 'upload_local_cover_images'}, > ]; > > my %cookies = fetch CGI::Cookie; >@@ -41,10 +41,10 @@ my %cookies = fetch CGI::Cookie; > my ($auth_status, $sessionID) = check_cookie_auth($cookies{'CGISESSID'}->value); > > my $auth_failure = 1; >-foreach my $flag_required (@{ $flags_required}) { >- if (my $flags = haspermission(C4::Context->config('user'), $flag_required)) { >- $auth_failure = 0 if $auth_status eq 'ok'; >- } >+foreach my $flag_required ( @{$flags_required} ) { >+ if ( my $flags = haspermission( C4::Context->config('user'), $flag_required ) ) { >+ $auth_failure = 0 if $auth_status eq 'ok'; >+ } > } > > if ($auth_failure) { >diff --git a/tools/upload-file.pl b/tools/upload-file.pl >index 2dd66f0..94a33a6 100755 >--- a/tools/upload-file.pl >+++ b/tools/upload-file.pl >@@ -39,19 +39,19 @@ use C4::UploadedFile; > # have been created. > > my $flags_required = [ >- {circulate => 'circulate_remaining_permissions'}, >- {tools => 'stage_marc_import'}, >- {tools => 'upload_local_cover_images'} >+ {circulate => 'circulate_remaining_permissions'}, >+ {tools => 'stage_marc_import'}, >+ {tools => 'upload_local_cover_images'} > ]; > > my %cookies = fetch CGI::Cookie; > > my $auth_failure = 1; >-my ($auth_status, $sessionID) = check_cookie_auth($cookies{'CGISESSID'}->value); >-foreach my $flag_required (@{ $flags_required}) { >- if (my $flags = haspermission(C4::Context->config('user'), $flag_required)) { >- $auth_failure = 0 if $auth_status eq 'ok'; >- } >+my ( $auth_status, $sessionID ) = check_cookie_auth( $cookies{'CGISESSID'}->value ); >+foreach my $flag_required ( @{$flags_required} ) { >+ if ( my $flags = haspermission( C4::Context->config('user'), $flag_required ) ) { >+ $auth_failure = 0 if $auth_status eq 'ok'; >+ } > } > > if ($auth_failure) { >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13663
:
35661
|
35882
|
40089
|
40123
|
40124
|
41380
| 41381