Bugzilla – Attachment 44002 Details for
Bug 14781
Creation of barcode types 2of5 not functional
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 14781 - Creation of barcode types 2of5 not functional
SIGNED-OFF-Bug-14781---Creation-of-barcode-types-2.patch (text/plain), 2.00 KB, created by
Bernardo Gonzalez Kriegel
on 2015-10-26 13:45:03 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 14781 - Creation of barcode types 2of5 not functional
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2015-10-26 13:45:03 UTC
Size:
2.00 KB
patch
obsolete
>From 62b4de250a6a2ea8a9d58c97d52233790f0a817c Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Fri, 4 Sep 2015 09:50:07 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 14781 - Creation of barcode types 2of5 not > functional > >This patch fixes the rendering of "COOP2of5" or "Industrial2of5" barcodes in the label creator module. > >To test: >- Create a label layout with COOP2of5 barcode type >- Create labels (make sure that the items's barcode values are numeric only!) >- Export batch and download PDF. > >Without patch: >- No barcodes rendered >With patch >- Barcodes should render as expected. Test for both barcode types. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Works as described, tested both formats. >Non digit barcode is not printed. > >No koha-qa errors, no t/ & xt/ errors >--- > C4/Labels/Label.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Labels/Label.pm b/C4/Labels/Label.pm >index ca12437..29e5a29 100644 >--- a/C4/Labels/Label.pm >+++ b/C4/Labels/Label.pm >@@ -548,7 +548,7 @@ sub barcode { > PDF::Reuse::Barcode::COOP2of5( > x => $params{'llx'}, > y => $params{'lly'}, >- value => "*$params{barcode_data}*", >+ value => $params{barcode_data}, > xSize => $x_scale_factor, > ySize => $params{'y_scale_factor'}, > mode => 'graphic', >@@ -566,7 +566,7 @@ sub barcode { > PDF::Reuse::Barcode::Industrial2of5( > x => $params{'llx'}, > y => $params{'lly'}, >- value => "*$params{barcode_data}*", >+ value => $params{barcode_data}, > xSize => $x_scale_factor, > ySize => $params{'y_scale_factor'}, > mode => 'graphic', >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14781
:
42378
|
42381
|
42382
|
42444
|
44002
|
44459