Attachment 44920 Details for Bug 14610 – Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP

[patch] Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP

Bug-14610-QA-Followup---Rename-ARPRINT-to-ARSLIP.patch (text/plain), 8.74 KB, created by Kyle M Hall (khall) on 2015-11-17 17:04:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-11-17 17:04:23 UTC

Size: 8.74 KB

patch

obsolete

>From cf3fc5aa36e0618ebcd89c443ae6bab19fc7bc73 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 30 Oct 2015 12:03:26 -0400
>Subject: [PATCH] Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP
>
>---
> circ/article-request-slip.pl                         |    2 +-
> installer/data/mysql/atomicupdate/bug_14610.sql      |    3 ++-
> installer/data/mysql/en/mandatory/sample_notices.sql |    2 +-
> 3 files changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/circ/article-request-slip.pl b/circ/article-request-slip.pl
>index 9d4008b..6a7087d 100755
>--- a/circ/article-request-slip.pl
>+++ b/circ/article-request-slip.pl
>@@ -46,7 +46,7 @@ $template->param( article_request => $ar );
> 
> my $slip = C4::Letters::GetPreparedLetter(
>     module                 => 'circulation',
>-    letter_code            => 'AR_PRINT',
>+    letter_code            => 'AR_SLIP',
>     message_transport_type => 'print',
>     tables                 => {
>         article_requests => $ar->id,
>diff --git a/installer/data/mysql/atomicupdate/bug_14610.sql b/installer/data/mysql/atomicupdate/bug_14610.sql
>index d4ab0ef..51b7366 100644
>--- a/installer/data/mysql/atomicupdate/bug_14610.sql
>+++ b/installer/data/mysql/atomicupdate/bug_14610.sql
>@@ -38,5 +38,6 @@ INSERT INTO `letter` (`module`, `code`, `branchcode`, `name`, `is_html`, `title`
> ('circulation', 'AR_CANCELED', '', 'Article Request - Email - Canceled', 0, 'Article Request Canceled', '<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nYour request for an article from <<biblio.title>> (<<items.barcode>>) has been canceled for the following reason:\r\n\r\n<<article_requests.notes>>\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n', 'email'),
> ('circulation', 'AR_COMPLETED', '', 'Article Request - Email - Completed', 0, 'Article Request Completed', '<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nWe are have completed your request for an article from <<biblio.title>> (<<items.barcode>>).\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n\r\nYou may pick your article up at <<branches.branchname>>.\r\n\r\nThank you!', 'email'),
> ('circulation', 'AR_OPEN', '', 'Article Request - Email - Open', 0, 'Article Request Recieved', '<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nWe have received your request for an article from <<biblio.title>> (<<items.barcode>>).\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n\r\n\r\nThank you!', 'email'),
>-('circulation', 'AR_PRINT', '', 'Article Request - Print Slip', 0, 'Test', 'Article Request:\r\n\r\n<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nTitle: <<biblio.title>>\r\nBarcode: <<items.barcode>>\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n', 'print'),
>+('circulation', 'AR_SLIP', '', 'Article Request - Print Slip', 0, 'Test', 'Article Request:\r\n\r\n<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nTitle: <<biblio.title>>\r\nBarcode: <<items.barcode>>\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n', 'print'),
> ('circulation', 'AR_PROCESSING', '', 'Article Request - Email - Processing', 0, 'Article Request Processing', '<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nWe are now processing your request for an article from <<biblio.title>> (<<items.barcode>>).\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n\r\nThank you!', 'email');
>+
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.sql b/installer/data/mysql/en/mandatory/sample_notices.sql
>index 4489082..d4c9026 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.sql
>+++ b/installer/data/mysql/en/mandatory/sample_notices.sql
>@@ -167,5 +167,5 @@ INSERT INTO `letter` (`module`, `code`, `branchcode`, `name`, `is_html`, `title`
> ('circulation', 'AR_CANCELED', '', 'Article Request - Email - Canceled', 0, 'Article Request Canceled', '<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nYour request for an article from <<biblio.title>> (<<items.barcode>>) has been canceled for the following reason:\r\n\r\n<<article_requests.notes>>\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n', 'email'),
>     ('circulation', 'AR_COMPLETED', '', 'Article Request - Email - Completed', 0, 'Article Request Completed', '<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nWe are have completed your request for an article from <<biblio.title>> (<<items.barcode>>).\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n\r\nYou may pick your article up at <<branches.branchname>>.\r\n\r\nThank you!', 'email'),
>     ('circulation', 'AR_OPEN', '', 'Article Request - Email - Open', 0, 'Article Request Recieved', '<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nWe have received your request for an article from <<biblio.title>> (<<items.barcode>>).\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n\r\n\r\nThank you!', 'email'),
>-    ('circulation', 'AR_PRINT', '', 'Article Request - Print Slip', 0, 'Test', 'Article Request:\r\n\r\n<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nTitle: <<biblio.title>>\r\nBarcode: <<items.barcode>>\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n', 'print'),
>+    ('circulation', 'AR_SLIP', '', 'Article Request - Print Slip', 0, 'Test', 'Article Request:\r\n\r\n<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nTitle: <<biblio.title>>\r\nBarcode: <<items.barcode>>\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n', 'print'),
>     ('circulation', 'AR_PROCESSING', '', 'Article Request - Email - Processing', 0, 'Article Request Processing', '<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nWe are now processing your request for an article from <<biblio.title>> (<<items.barcode>>).\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\n\r\nThank you!', 'email');
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14610: 42822 | 42823 | 42824 | 42825 | 42826 | 42827 | 42828 | 42829 | 43198 | 43199 | 43200 | 43201 | 43202 | 43264 | 43265 | 43266 | 43267 | 43268 | 43270 | 43271 | 43272 | 43273 | 43274 | 43278 | 43279 | 43280 | 43281 | 43282 | 43654 | 43655 | 43656 | 43657 | 43658 | 44219 | 44220 | 44221 | 44222 | 44223 | 44224 | 44225 | 44226 | 44227 | 44228 | 44229 | 44230 | 44231 | 44232 | 44233 | 44234 | 44235 | 44236 | 44237 | 44238 | 44239 | 44240 | 44241 | 44242 | 44916 | 44917 | 44918 | 44919 | 44920 | 44921 | 44922 | 44923 | 44924 | 44925 | 44926 | 45946 | 45947 | 45948 | 45949 | 45950 | 45951 | 45952 | 45953 | 45954 | 45955 | 45956 | 46518 | 46519 | 46520 | 46521 | 46522 | 46523 | 46524 | 46525 | 46526 | 46527 | 46528 | 46529 | 46530 | 46595 | 46596 | 46597 | 46598 | 46599 | 46600 | 46601 | 46602 | 46603 | 46604 | 46605 | 46606 | 46607 | 46608 | 46609 | 46610 | 46611 | 46612 | 47905 | 47906 | 47907 | 47908 | 47909 | 47910 | 47911 | 47912 | 47913 | 47914 | 47915 | 47916 | 47917 | 47918 | 47919 | 47920 | 47921 | 47922 | 48177 | 48178 | 48179 | 48180 | 48181 | 48182 | 48212 | 48213 | 48214 | 48215 | 48216 | 48217 | 48218 | 50348 | 50349 | 50350 | 50351 | 50352 | 50353 | 50354 | 51527 | 51528 | 51529 | 51530 | 51531 | 51532 | 51533 | 51534 | 51778 | 51779 | 51780 | 51781 | 51782 | 51783 | 52688 | 52689 | 52690 | 52691 | 52692 | 52693 | 55556 | 55557 | 55558 | 55559 | 55560 | 55561 | 55568 | 55569 | 56084 | 56085 | 56086 | 56087 | 56088 | 56089 | 56090 | 56318 | 56319 | 56320 | 56321 | 56322 | 56323 | 56324 | 56325 | 56326 | 56327 | 56328 | 56775 | 56776 | 56777 | 56778 | 56779 | 56780 | 56781 | 56782 | 56783 | 56784 | 56785 | 56816 | 56854 | 56855 | 56856 | 56857 | 56858 | 56859 | 56860 | 56861 | 56862 | 56863 | 56864 | 56865