Attachment 46166 Details for Bug 15135 – Bug 15135: Get rid of Warning 'Subroutine HasOverdues redefined'

[patch] Bug 15135: Get rid of Warning 'Subroutine HasOverdues redefined'

Bug-15135-Get-rid-of-Warning-Subroutine-HasOverdue.patch (text/plain), 2.39 KB, created by Chris Cormack on 2016-01-01 02:44:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2016-01-01 02:44:34 UTC

Size: 2.39 KB

patch

obsolete

>From e8468b4327d1321aa4b98134fbd65f1bc00bb2d4 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Wed, 30 Dec 2015 14:37:03 +0100
>Subject: [PATCH] Bug 15135: Get rid of Warning 'Subroutine HasOverdues
> redefined'
>
>This patch renames the subroutine HasOverdues to WithOverdues in
>Koha/Template/Plugin/Borrowers.pm and in members-toolbar.inc (only
>place where it is used).
>
>To test:
>- First test without patch
>- Search for a patron with overdues (I used the 'Overdues' report
>  on page Home > Cirulation
>- Display detail page, open drop down tool 'Print'. Verify that you have
>  an item 'Print overdues'
>- Apply patch
>- Repeat steps above. Verify that the item 'Print overdues' still
>  appears
>- Search for remaining occurences of HasOverdues in template files / template
>  includes with git grep 'Patrons.HasOverdues'. There should not be any
>  occurences.
>
>Signed-off-by: Chris <chris@bigballofwax.co.nz>
>---
> Koha/Template/Plugin/Borrowers.pm                            |    2 +-
> koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc |    2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Template/Plugin/Borrowers.pm b/Koha/Template/Plugin/Borrowers.pm
>index 3e2c59b..1918017 100644
>--- a/Koha/Template/Plugin/Borrowers.pm
>+++ b/Koha/Template/Plugin/Borrowers.pm
>@@ -49,7 +49,7 @@ sub IsDebarred {
>     return Koha::Borrower::Debarments::IsDebarred($borrower->{borrowernumber});
> }
> 
>-sub HasOverdues {
>+sub WithOverdues {
>     my ( $self, $borrowernumber ) = @_;
> 
>     return unless $borrowernumber;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>index 641bbad..c30d447 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>@@ -160,7 +160,7 @@ function searchToHold(){
>                 [% IF ( CAN_user_borrowers ) %]<li><a id="printsummary" href="#">Print summary</a></li>[% END %]
>                 <li><a id="printslip" href="#">Print slip</a></li>
>                 <li><a id="printquickslip" href="#">Print quick slip</a></li>
>-                [% IF Borrowers.HasOverdues( borrowernumber ) %]
>+                [% IF Borrowers.WithOverdues( borrowernumber ) %]
>                     <li><a id="print_overdues" href="#">Print overdues</a></li>
>                 [% END %]
>             </ul>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 15135: 44466 | 44536 | 45172 | 46083 | 46166 | 46478 | 46479 | 46481