Bugzilla – Attachment 47321 Details for
Bug 15343
Allow patrons to choose their own password on self registration.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15343 [QA Followup] - Fix issues
Bug-15343-QA-Followup---Fix-issues.patch (text/plain), 4.34 KB, created by
Jesse Weaver
on 2016-01-26 22:32:16 UTC
(
hide
)
Description:
Bug 15343 [QA Followup] - Fix issues
Filename:
MIME Type:
Creator:
Jesse Weaver
Created:
2016-01-26 22:32:16 UTC
Size:
4.34 KB
patch
obsolete
>From aa4063809025d0395c914ec66f2f5dcd642a2637 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 18 Dec 2015 19:30:13 +0000 >Subject: [PATCH] Bug 15343 [QA Followup] - Fix issues > >1) "Contact information" should be "Password" >2) Don't pass sysprefs from the script to the template, use Koha.Preference() >3) minPasswordLength is optional, we cannot always assume it is set >4) Password field when does not follow convention completely when mandatory > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> > >Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> >--- > .../bootstrap/en/modules/opac-memberentry.tt | 22 +++++++++++++++------- > opac/opac-memberentry.pl | 1 - > 2 files changed, 15 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index 90f4b83..a57ab0c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -778,23 +778,32 @@ > </fieldset> > [% END %] > >- [% UNLESS action == 'edit' %] >+ [% UNLESS action == 'edit' || hidden.defined('password') %] > <fieldset class="rows" id="memberentry_password"> >- <legend id="contact_legend">Contact information</legend> >- [% UNLESS hidden.defined('password') %] >- <div class="alert alert-info">Your password must be at least [% minpassw %] characters long. >+ <legend id="contact_legend">Password</legend> >+ [% IF Koha.Preference('minPasswordLength') || !mandatory.defined('password') %] >+ <div class="alert alert-info"> >+ [% IF Koha.Preference('minPasswordLength') %] >+ <p>Your password must be at least [% Koha.Preference('minPasswordLength') %] characters long.</p> >+ [% END %] >+ [% UNLESS mandatory.defined('password') %] >+ If you do not enter a password a system generated password will be created. >+ [% END %] >+ </div> >+ [% END %] >+ > [% IF mandatory.defined('password') %] >- <br>You must enter a password!</div> > <ol> > <li><label for="borrower_password" class="required">Password</label> > <input type="text" name="borrower_password" id="password" /> >+ <span class="required">Required</span> > </li> > <li><label for="borrower_password2" class="required">Confirm password</label> > <input type="text" name="borrower_password2" id="password2" /> >+ <span class="required">Required</span> > </li> > </ol> > [% ELSE %] >- <br>If you do not enter a password a system generated password will be created</div> > <ol> > <li><label for="borrower_password">Password</label> > <input type="text" name="borrower_password" id="password" /> >@@ -804,7 +813,6 @@ > </li> > </ol> > [% END %] >- [% END %] > </fieldset> > > <fieldset class="rows" id="memberentry_captcha"> >diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl >index fcf94cf..da9e186 100755 >--- a/opac/opac-memberentry.pl >+++ b/opac/opac-memberentry.pl >@@ -67,7 +67,6 @@ $template->param( > action => $action, > hidden => $hidden, > mandatory => $mandatory, >- minpassw => C4::Context->preference('minPasswordLength'), > member_titles => GetTitles() || undef, > branches => GetBranchesLoop(), > OPACPatronDetails => C4::Context->preference('OPACPatronDetails'), >-- >2.6.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15343
:
45861
|
45866
|
45867
|
45868
|
45869
|
46705
|
46737
|
47320
|
47321
|
47322
|
47407
|
47408
|
47409
|
47705
|
47794
|
47795
|
47796
|
47797