Bugzilla – Attachment 48230 Details for
Bug 14507
SIP Authentication broken when LDAP Auth Enabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14507 [QA Followup] - Restore comment, tidy sub
Bug-14507-QA-Followup---Restore-comment-tidy-sub.patch (text/plain), 1.15 KB, created by
Kyle M Hall
on 2016-02-19 12:52:13 UTC
(
hide
)
Description:
Bug 14507 [QA Followup] - Restore comment, tidy sub
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2016-02-19 12:52:13 UTC
Size:
1.15 KB
patch
obsolete
>From 4f0f1a96284aa52223b87a4db3224dd766409472 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 19 Feb 2016 12:51:21 +0000 >Subject: [PATCH] Bug 14507 [QA Followup] - Restore comment, tidy sub > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/SIP/ILS/Patron.pm | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm >index fe21903..33653b9 100644 >--- a/C4/SIP/ILS/Patron.pm >+++ b/C4/SIP/ILS/Patron.pm >@@ -192,17 +192,17 @@ sub AUTOLOAD { > } > > sub check_password { >- my ($self, $pwd) = @_; >+ my ( $self, $pwd ) = @_; > >- defined $pwd or return 0; # you gotta give me something (at least ''), or no deal >+ defined $pwd >+ or return 0; # you gotta give me something (at least ''), or no deal > >- if ($pwd eq q{}) { >- return 1; >- } >+ return 1 >+ if $pwd eq q{}; # if the record has a NULL password, accept '' as match > > my $dbh = C4::Context->dbh; > my $ret = 0; >- ($ret) = checkpw($dbh, $self->{userid}, $pwd); >+ ($ret) = checkpw( $dbh, $self->{userid}, $pwd ); > return $ret; > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14507
:
41379
|
48045
|
48229
| 48230