Bugzilla – Attachment 50265 Details for
Bug 7957
Routing lists: manage several routing list for each subscription, and export them as CSV
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7957: QA fixes (tabs, POD, GPL version)
Bug-7957-QA-fixes-tabs-POD-GPL-version.patch (text/plain), 8.05 KB, created by
Julian Maurice
on 2016-04-15 10:54:28 UTC
(
hide
)
Description:
Bug 7957: QA fixes (tabs, POD, GPL version)
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2016-04-15 10:54:28 UTC
Size:
8.05 KB
patch
obsolete
>From 5c78a1b604c455a47f2670d1300e02e0f8e49c22 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 15 Apr 2016 12:30:42 +0200 >Subject: [PATCH] Bug 7957: QA fixes (tabs, POD, GPL version) > >--- > C4/Items.pm | 12 ++++++------ > C4/Serials/RoutingLists.pm | 34 ++++++++++++++++++++++++---------- > serials/routing-preview-slip.pl | 20 ++++++++++---------- > serials/routinglist.pl | 20 ++++++++++---------- > serials/routinglists.pl | 20 ++++++++++---------- > 5 files changed, 60 insertions(+), 46 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index f183c6b..d7bbf84 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -173,14 +173,14 @@ sub GetItem { > $ssth->execute($data->{'itemnumber'}) ; > ($data->{'serialseq'} , $data->{'publisheddate'}) = $ssth->fetchrow_array(); > } >- #if we don't have an items.itype, use biblioitems.itemtype. >+ #if we don't have an items.itype, use biblioitems.itemtype. > # FIXME this should respect the itypes systempreference > # if (C4::Context->preference('item-level_itypes')) { >- if( $data and ! $data->{'itype'} ) { >- my $sth = $dbh->prepare("SELECT itemtype FROM biblioitems WHERE biblionumber = ?"); >- $sth->execute($data->{'biblionumber'}); >- ($data->{'itype'}) = $sth->fetchrow_array; >- } >+ if( $data and ! $data->{'itype'} ) { >+ my $sth = $dbh->prepare("SELECT itemtype FROM biblioitems WHERE biblionumber = ?"); >+ $sth->execute($data->{'biblionumber'}); >+ ($data->{'itype'}) = $sth->fetchrow_array; >+ } > return $data; > } # sub GetItem > >diff --git a/C4/Serials/RoutingLists.pm b/C4/Serials/RoutingLists.pm >index a891d86..9f7ad52 100644 >--- a/C4/Serials/RoutingLists.pm >+++ b/C4/Serials/RoutingLists.pm >@@ -4,18 +4,18 @@ package C4::Serials::RoutingLists; > # > # This file is part of Koha. > # >-# Koha is free software; you can redistribute it and/or modify it under the >-# terms of the GNU General Public License as published by the Free Software >-# Foundation; either version 2 of the License, or (at your option) any later >-# version. >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. > # >-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >-# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. > # >-# You should have received a copy of the GNU General Public License along >-# with Koha; if not, write to the Free Software Foundation, Inc., >-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; > >@@ -38,6 +38,20 @@ BEGIN { > ); > } > >+=head1 NAME >+ >+C4::Serials::RoutingLists >+ >+=head1 SYNOPSYS >+ >+use C4::Serials::RoutingLists; >+ >+=head1 DESCRIPTION >+ >+This module provides subroutines to deal with subscriptions routing lists >+ >+=head1 FUNCTIONS >+ > =head2 AddRoutingList > > $routinglistid = &AddRoutingList($subscriptionid, $title); >diff --git a/serials/routing-preview-slip.pl b/serials/routing-preview-slip.pl >index 44acf21..457fc08 100755 >--- a/serials/routing-preview-slip.pl >+++ b/serials/routing-preview-slip.pl >@@ -3,18 +3,18 @@ > # Copyright 2011 BibLibre SARL > # This file is part of Koha. > # >-# Koha is free software; you can redistribute it and/or modify it under the >-# terms of the GNU General Public License as published by the Free Software >-# Foundation; either version 2 of the License, or (at your option) any later >-# version. >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. > # >-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >-# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. > # >-# You should have received a copy of the GNU General Public License along >-# with Koha; if not, write to the Free Software Foundation, Inc., >-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. > > =head1 NAME > >diff --git a/serials/routinglist.pl b/serials/routinglist.pl >index d1e4b86..de772db 100755 >--- a/serials/routinglist.pl >+++ b/serials/routinglist.pl >@@ -3,18 +3,18 @@ > # Copyright 2011 BibLibre SARL > # This file is part of Koha. > # >-# Koha is free software; you can redistribute it and/or modify it under the >-# terms of the GNU General Public License as published by the Free Software >-# Foundation; either version 2 of the License, or (at your option) any later >-# version. >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. > # >-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >-# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. > # >-# You should have received a copy of the GNU General Public License along >-# with Koha; if not, write to the Free Software Foundation, Inc., >-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. > > =head1 NAME > >diff --git a/serials/routinglists.pl b/serials/routinglists.pl >index cb646c6..be12bf6 100755 >--- a/serials/routinglists.pl >+++ b/serials/routinglists.pl >@@ -3,18 +3,18 @@ > # Copyright 2011 BibLibre SARL > # This file is part of Koha. > # >-# Koha is free software; you can redistribute it and/or modify it under the >-# terms of the GNU General Public License as published by the Free Software >-# Foundation; either version 2 of the License, or (at your option) any later >-# version. >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. > # >-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >-# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. > # >-# You should have received a copy of the GNU General Public License along >-# with Koha; if not, write to the Free Software Foundation, Inc., >-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. > > =head1 NAME > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7957
:
9259
|
10973
|
13217
|
16614
|
21340
|
22726
|
35709
|
35801
|
35802
|
35803
|
35804
|
35842
|
35860
|
35872
|
35873
|
35874
|
35875
|
38425
|
41762
|
41763
|
41764
|
42427
|
42428
|
42429
|
47633
|
47634
|
47635
|
47659
|
47660
|
47661
|
47662
|
47663
|
47664
|
50226
|
50227
|
50228
|
50265
|
50266
|
50270
|
50273
|
97519
|
97520
|
97521
|
97522
|
97523
|
97524