Bugzilla – Attachment 50711 Details for
Bug 16231
Correct permission handling in subscription edit menu
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16231 [Follow-up] Correct permission handling in subscription edit menu
Bug-16231-Follow-up-Correct-permission-handling-in.patch (text/plain), 2.07 KB, created by
Chris Cormack
on 2016-04-26 08:58:29 UTC
(
hide
)
Description:
Bug 16231 [Follow-up] Correct permission handling in subscription edit menu
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2016-04-26 08:58:29 UTC
Size:
2.07 KB
patch
obsolete
>From 527b4c66e11f821863ac93140fbd12c90961059c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 25 Apr 2016 10:23:58 -0400 >Subject: [PATCH] Bug 16231 [Follow-up] Correct permission handling in > subscription edit menu > >This follow-up allows for the case where the user has only >"delete_subscription" permission. The delete option might be >available even if the template's "cannotedit" variable is true. > >To test, apply the patch and revise a staff user's permission to have >only the "delete_subscription" permission under Serials. > >Log in as that users and locate a subscription and view the details for >that subscription. You should see a toolbar on that page containing only >a "Delete" button. > >Repeat the steps above, adding serials permission to the user one by >one, confirming that the toolbar continues to show the correct options. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc >index b79dd45..5722b21 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc >@@ -46,7 +46,11 @@ > [% END %] > > [% IF ( CAN_user_serials_edit_subscription || CAN_user_serials_create_subscription || CAN_user_serials_delete_subscription ) %] >- [% UNLESS ( cannotedit ) %] >+ [% IF ( cannotedit ) %] >+ [% IF ( CAN_user_serials_delete_subscription ) %] >+ <div class="btn-group"><a class="btn btn-small" href="#" id="deletesub"><i class="fa fa-trash"></i> Delete</a></div> >+ [% END %] >+ [% ELSE %] > <div class="btn-group"> > <button class="btn btn-small dropdown-toggle" data-toggle="dropdown"><i class="fa fa-pencil"></i> Edit <span class="caret"></span></button> > <ul class="dropdown-menu"> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16231
:
50089
|
50195
|
50639
|
50711
|
79904
|
82336
|
83833
|
84680