Attachment 57183 Details for Bug 15896 – Bug 15896: [QA Follow-up] Add accountlines_id parameter in paycollect

[patch] Bug 15896: [QA Follow-up] Add accountlines_id parameter in paycollect

Bug-15896-QA-Follow-up-Add-accountlinesid-paramete.patch (text/plain), 1.93 KB, created by Marcel de Rooy on 2016-11-04 12:36:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2016-11-04 12:36:02 UTC

Size: 1.93 KB

patch

obsolete

>From 6107aab0e659ba2720138ab8d20a1b7916d9b5d8 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 4 Nov 2016 11:39:12 +0100
>Subject: [PATCH] Bug 15896: [QA Follow-up] Add accountlines_id parameter in
> paycollect
>Content-Type: text/plain; charset=utf-8
>
>We can solve the minor problem reported on 15906 now by using the
>accountlines_id parameter of this report.
>
>Test plan:
>[1] Add two manual fines (say 20 and 30).
>[2] Pay the second one in full, and check that the first one is not paid
>    first. So the 20 should remain and not the 30 with 20 outstanding.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> members/paycollect.pl |   15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
>diff --git a/members/paycollect.pl b/members/paycollect.pl
>index b341e8c..b34dba6 100755
>--- a/members/paycollect.pl
>+++ b/members/paycollect.pl
>@@ -112,15 +112,12 @@ if ( $total_paid and $total_paid ne '0.00' ) {
>     } else {
>         if ($individual) {
>             if ( $total_paid == $total_due ) {
>-                my $line = Koha::Account::Lines->find($accountlines_id);
>-                Koha::Account->new( { patron_id => $borrowernumber } )->pay(
>-                    {
>-                        lines      => [$line],
>-                        amount     => $total_paid,
>-                        library_id => $branch,
>-                        note       => $payment_note
>-                    }
>-                );
>+                Koha::Account->new( { patron_id => $borrowernumber } )->pay({
>+                    accountlines_id => $accountlines_id,
>+                    amount          => $total_paid,
>+                    library_id      => $branch,
>+                    note            => $payment_note,
>+                });
>             } else {
>                 makepartialpayment( $accountlines_id, $borrowernumber, $accountno, $total_paid,
>                     $user, $branch, $payment_note );
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 15896: 48332 | 51920 | 52139 | 53314 | 53782 | 53783 | 53784 | 53785 | 53786 | 55924 | 55925 | 57175 | 57176 | 57177 | 57178 | 57182 | 57183 | 57184 | 57185 | 57186 | 57187 | 57188 | 57189 | 57190 | 57191 | 57192 | 57193