Attachment 57690 Details for Bug 17616 – Bug 17616: Select tag on elasticsearch mappings page is not closed properly

[patch] Bug 17616: Select tag on elasticsearch mappings page is not closed properly

Bug-17616-Select-tag-on-elasticsearch-mappings-pag.patch (text/plain), 1.58 KB, created by Jonathan Druart on 2016-11-22 08:48:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-11-22 08:48:22 UTC

Size: 1.58 KB

patch

obsolete

>From 696a612abd928971d6e1b0a08a125d5dfe5fa6f6 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Fri, 11 Nov 2016 16:48:15 +0000
>Subject: [PATCH] Bug 17616: Select tag on elasticsearch mappings page is not
> closed properly
>
>Test plan
>1) Have SearchEngine syspref set to Elastic
>2) Look at source on admin/searchengine/elasticsearch/mappings.pl
>-> without patch you'll see select with attribute
>   data-id="mapping_search_field_name" closing tag written badly as
>   "/select>"
>-> with patch everything looks OK
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> .../prog/en/modules/admin/searchengine/elasticsearch/mappings.tt        | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
>index 154f06e..90d5b35 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
>@@ -247,7 +247,7 @@ a.add, a.delete {
>                              [% FOREACH f IN all_search_fields %]
>                                <option value="[% f.name %]">[% f.name %]</option>
>                              [% END %]
>-                            /select>
>+                            </select>
>                           </td>
>                           <td>
>                             <select data-id="mapping_sort">
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17616: 57460 | 57472 | 57682 | 57683 | 57690 | 57691