Bugzilla – Attachment 58662 Details for
Bug 17855
New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17855 - Working insertion of library, patron category, patron (with superlibrarian permissions asssigned), and item type
Bug-17855---Working-insertion-of-library-patron-ca.patch (text/plain), 28.79 KB, created by
Alex Buckley
on 2017-01-08 23:27:38 UTC
(
hide
)
Description:
Bug 17855 - Working insertion of library, patron category, patron (with superlibrarian permissions asssigned), and item type
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2017-01-08 23:27:38 UTC
Size:
28.79 KB
patch
obsolete
>From f635c1c0a194bd46d15915bc548a1e61663186cc Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Fri, 16 Dec 2016 01:47:55 +0000 >Subject: [PATCH] Bug 17855 - Working insertion of library, patron category, > patron (with superlibrarian permissions asssigned), and item type > >Create circulation screens backend >code to insert a circulation rule into the >database not yet working. > >Bug 17855 - Same as previous patch with >some minor changes to the code for step 2 >(creating a patron category) in onboarding.pl > >Bug 17855 - Same as previous patch except >made changes to the perl code >for creating a patron category which is >step 2 in the onboarding.pl script > >Bug 17855 - Successful insertion from onboarding tool >of library, patron category, patron and item type. > >Successful checking if library, patron category and item >type has been installed with web installer, and if they have been >installed then the appropriate onboarding tool step is skipped. > >Bug 17855 - Working insertion of library, patron >category and patron as well as checks for library, patron >category, and item type in the onboarding tool. > >i.e. Very similar to the previous patch > >Error messages working for create library. In progress for patron >category. > >Fixing the item type error handling. Still in progress. > >Correctly inserting patron so they can now log >in with the patron account they create on the onboarding tool >(no superlibrarian permissions yet) but the dropdown boxes on the >create circulation rule screen no longer work > >Fixed some things I broke in patron category > >Fixed more of patron category. Should be working normally but >error handling still not implemented. > >Same as previous > >Working insertion of the patron into the >borrowers table and setting of superlibrarian >permissions so the user can log in with the patron they create >in the onboarding tool however the dropdown boxes >in the create circulation rule screen now >do not work >--- > installer/onboarding.pl | 212 +++++++++++---------- > .../prog/en/modules/onboarding/onboardingstep1.tt | 43 +++-- > .../prog/en/modules/onboarding/onboardingstep2.tt | 30 ++- > .../prog/en/modules/onboarding/onboardingstep3.tt | 32 ++-- > .../prog/en/modules/onboarding/onboardingstep4.tt | 46 +++-- > 5 files changed, 207 insertions(+), 156 deletions(-) > >diff --git a/installer/onboarding.pl b/installer/onboarding.pl >index aac1705..bea4e65 100755 >--- a/installer/onboarding.pl >+++ b/installer/onboarding.pl >@@ -41,17 +41,6 @@ use Koha::Token; > use Email::Valid; > use Module::Load; > >-#Imports for item types step 4 >-use Koha::ItemTypes; >-use Koha::Localizations; >- >-#Imports for circulation rule step 5 >-use Koha::IssuingRule; >-use Koha::IssuingRules; >-use Koha::Logger; >-use Koha::RefundLostItemFeeRule; >-use Koha::RefundLostItemFeeRules; >- > #Setting variables > my $input = new CGI; > my $query = new CGI; >@@ -124,7 +113,6 @@ if ( $start && $start eq 'Start setting up my Koha' ){ > > }elsif ( $start && $start eq 'Add an item type' ){ > my $itemtypes = Koha::ItemTypes->search(); >- warn $itemtypes; > $template->param( > itemtypes => $itemtypes, > ); >@@ -139,18 +127,23 @@ if ( $start && $start eq 'Start setting up my Koha' ){ > my $branchcode = $input->param('branchcode'); > my $categorycode = $input->param('categorycode'); > my $op = $input->param('op') || 'list'; >- my @messages; >+ my $message; > my $library; >+#my @messages; > > #Take the text 'branchname' and store it in the @fields array > my @fields = qw( > branchname > ); > >+ >+#test >+ $template->param('branchcode'=>$branchcode); >+ > $branchcode =~ s|\s||g; # Use a regular expression to check the value of the inputted branchcode > > #Create a new library object and store the branchcode and @fields array values in this new library object >- my $library = Koha::Library->new( >+ $library = Koha::Library->new( > { branchcode => $branchcode, > ( map { $_ => scalar $input->param($_) || undef } @fields ) > } >@@ -158,22 +151,28 @@ if ( $start && $start eq 'Start setting up my Koha' ){ > > eval { $library->store; }; #Use the eval{} function to store the library object > >- #If there are values in the $@ then push the values type => 'alert', code => 'error_on_insert' into the @messages array el se push the values type => 'message', code => 'success_on_insert' to that array >- if ($@) { >- push @messages, { type => 'alert', code => 'error_on_insert' }; >- } else { >- push @messages, { type => 'message', code => 'success_on_insert' }; >- } >+ if($library){ >+ $message = 'success_on_insert'; >+ }else{ >+ $message = 'error_on_insert'; >+ } >+ >+ $template->param('message' => $message); >+ > > #Check if the $step vairable equals 2 i.e. the user has clicked to create a patron category in the create patron category screen 1 > }elsif ( $step && $step == 2 ){ >+ my $createcat = $query->param('createcat'); #Store the inputted library branch code and name in $createlibrary >+ $template->param('createcat'=>$createcat); # Hand the library values back to the template in the createlibrary variable >+ > > #Initialising values > my $input = new CGI; > my $searchfield = $input->param('description') // q||; > my $categorycode = $input->param('categorycode'); > my $op = $input->param('op') // 'list'; >- my @messages; >+ my $message; >+ my $category; > > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > { >@@ -185,25 +184,12 @@ if ( $start && $start eq 'Start setting up my Koha' ){ > debug => 1, > } > ); >- #When the user first arrives on the page >- if ( $op eq 'add_form' ) { >- my $category; >- if ($categorycode) { >- $category = Koha::Patron::Categories->find($categorycode); >- } >- >- $template->param( >- category => $category, >- ); >+ > >- if ( C4::Context->preference('EnhancedMessagingPreferences') ) { >- C4::Form::MessagingPreferences::set_form_values( >- { categorycode => $categorycode }, $template ); >- } >- } > #Once the user submits the page, this code validates the input and adds it > #to the database as a new patron category >- elsif ( $op eq 'add_validate' ) { >+#} elsif ( $op eq 'add_validate' ) { >+ > my $categorycode = $input->param('categorycode'); > my $description = $input->param('description'); > my $overduenoticerequired = $input->param('overduenoticerequired'); >@@ -223,7 +209,7 @@ if ( $start && $start eq 'Start setting up my Koha' ){ > ); > } > #Adds to the database >- my $category = Koha::Patron::Category->new({ >+ $category = Koha::Patron::Category->new({ > categorycode=> $categorycode, > description => $description, > overduenoticerequired => $overduenoticerequired, >@@ -236,13 +222,15 @@ if ( $start && $start eq 'Start setting up my Koha' ){ > $category->store; > }; > >- #Error messages >- if($@){ >- push @messages, {type=> 'error', code => 'error_on_insert'}; >+ #Error messages >+ if($category){ >+ $message = 'success_on_insert'; > }else{ >- push @messages, {type=> 'message', code => 'success_on_insert'}; >+ $message = 'error_on_insert'; > } >- } >+ >+ $template->param('message' => $message); >+ > #Create a patron > }elsif ( $step && $step == 3 ){ > >@@ -258,73 +246,101 @@ if ( $start && $start eq 'Start setting up my Koha' ){ > ] > ); > >- my $categories; >- $categories= Koha::Patron::Categories->search(); >- $template->param( >- categories => $categories, >- ); >- >+ my $categories; >+ $categories= Koha::Patron::Categories->search(); >+ $template->param( >+ categories => $categories, >+ ); > > > my $input = new CGI; >- my $op = $input->param('op'); >+ my $op = $input->param('op') // 'list'; >+ > my @messages; > >- my ($template, $loggedinuser, $cookie) >- = get_template_and_user({ >+ my ($template, $loggedinuser, $cookie)= get_template_and_user({ > template_name => "/onboarding/onboardingstep3.tt", > query => $input, > type => "intranet", > authnotrequired => 0, > flagsrequired => {borrowers => 1}, > debug => 1, >- }); >+ }); > > if($op eq 'add_form'){ > my $member; > $template->param( > member => $member, > ); >- >- > } >+ > elsif($op eq 'add_validate'){ >- my $surname => $input->param('surname'); >- my $firstname => $input->param('firstname'); >- my $cardnumber => $input->param('cardnumber'); >- my $libraries => $input->param('libraries'); >- my $categorycode_entry => $input->param('categorycode_entry'); >- my $userid => $input->param('userid'); >- my $password => $input->param('password'); >- my $password2 =>$input->param('password2'); >- >- my $member = Koha::Patron->new({ >- surname => $surname, >- firstname => $firstname, >- cardnumber => $cardnumber, >- libraries => $libraries, >- categorycode_entry => $categorycode_entry, >- userid => $userid, >- password => $password, >- password2 => $password2, >- }); >- eval { >- $member->store; >- }; >- if($@){ >+ >+ my %newdata; >+ >+#Store the template form values in the newdata hash >+ $newdata{borrowernumber} = $input->param('borrowernumber'); >+ $newdata{surname} = $input->param('surname'); >+ $newdata{firstname} = $input->param('firstname'); >+ $newdata{cardnumber} = $input->param('cardnumber'); >+ $newdata{branchcode} = $input->param('libraries'); >+ $newdata{categorycode} = $input->param('categorycode_entry'); >+ $newdata{userid} = $input->param('userid'); >+ $newdata{password} = $input->param('password'); >+ $newdata{password2} = $input->param('password2'); >+ $newdata{dateexpiry} = '12/10/2016'; >+ >+#Hand the newdata hash to the AddMember subroutine in the C4::Members module and it creates a patron and hands back a borrowernumber which is being stored >+ my $borrowernumber = &AddMember(%newdata); >+ my %member2; >+ $member2{'borrowernumber'}=$borrowernumber; >+ >+ my $flag = $input->param('flag'); >+ >+ if ($input->param('newflags')) { >+ my $dbh=C4::Context->dbh(); >+ my @perms = $input->multi_param('flag'); >+ my %all_module_perms = (); >+ my %sub_perms = (); >+ foreach my $perm (@perms) { >+ if ($perm !~ /:/) { >+ $all_module_perms{$perm} = 1; >+ } else { >+ my ($module, $sub_perm) = split /:/, $perm, 2; >+ push @{ $sub_perms{$module} }, $sub_perm; >+ } >+ } >+ >+ >+ # construct flags >+ my $module_flags = 0; >+ my $sth=$dbh->prepare("SELECT bit,flag FROM userflags ORDER BY bit"); >+ $sth->execute(); >+ while (my ($bit, $flag) = $sth->fetchrow_array) { >+ if (exists $all_module_perms{$flag}) { >+ $module_flags += 2**$bit; >+ } >+ } >+ >+ $sth = $dbh->prepare("UPDATE borrowers SET flags=? WHERE borrowernumber=?"); >+ $sth->execute($module_flags, $borrowernumber); >+ >+ >+#Error handling checking if the patron was created successfully >+ if(!$borrowernumber){ > push @messages, {type=> 'error', code => 'error_on_insert'}; >- }else{ >+ }else{ > push @messages, {type=> 'message', code => 'success_on_insert'}; >- } >- >+ } > } >- >-#Create item type > }elsif ( $step && $step == 4){ >+ my $createitemtype = $input->param('createitemtype'); >+ $template->param('createitemtype'=> $createitemtype ); >+ > my $input = new CGI; > my $itemtype_code = $input->param('itemtype'); > my $op = $input->param('op') // 'list'; >- my @messages; >+ my $message; > > my( $template, $borrowernumber, $cookie) = get_template_and_user( > { template_name => "/onboarding/onboardingstep4.tt", >@@ -338,7 +354,7 @@ if ( $start && $start eq 'Start setting up my Koha' ){ > > if($op eq 'add_form'){ > my $itemtype = Koha::ItemTypes->find($itemtype_code); >- template->param(itemtype=>$itemtype,); >+ $template->param(itemtype=> $itemtype,); > }elsif($op eq 'add_validate'){ > my $itemtype = Koha::ItemTypes->find($itemtype_code); > my $description = $input->param('description'); >@@ -351,11 +367,13 @@ if ( $start && $start eq 'Start setting up my Koha' ){ > ); > eval{ $itemtype->store; }; > #Error messages >- if($@){ >- push @messages, {type=> 'error', code => 'error_on_insert'}; >+ if($itemtype){ >+ $message = 'success_on_insert'; > }else{ >- push @messages, {type=> 'message', code => 'success_on_insert'}; >+ $message = 'error_on_insert'; > } >+ >+ $template->param('message' => $message); > } > > }elsif ( $step && $step == 5){ >@@ -381,12 +399,12 @@ if ( $start && $start eq 'Start setting up my Koha' ){ > flagsrequired=> {parameters => 'manage_circ_rules'}, > debug =>1, > }); >- >+ > my $type = $input->param('type'); > my $branch = $input->param('branch'); >- >- >- >+ >+ >+ > if($op eq 'add_form'){ > > >@@ -418,17 +436,13 @@ if ( $start && $start eq 'Start setting up my Koha' ){ > }else{ > Koha::IssuingRule->new()->set($params)->store(); > } >- >- > } >- >- >- > >+ my $createcirculationrule = $query->param('createcirculationrule'); >+ $template->param('createcirculationrule'=>$createcirculationrule); > } > >- >- >+} > > output_html_with_http_headers $input, $cookie, $template->output; > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt >index 92f741b..07d0809 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt >@@ -52,30 +52,37 @@ > <!--Create a library screen 2--> > [% ELSIF (createlibrary) %] > <!--New Library created--> >- <form name="createlibrary" method="post" action="onboarding.pl"> >- <input type="hidden" name="step" value="2"/> >- <h1 align="left"> New Library</h1> >- <div> >- <p> Success: Library created!</p> >- <p> To add another library and for more settings, <br> >- go to Tools->Administration->Libraries and Groups >- </div> >- Next up: >- <input type="submit" name="start" value="Add a patron category"/> >- </form> >- >- <!--Implement if statement to determine if library was succesfully created here....- >- <div> >- <p> Library was not successfully created</p> >- </div> >- --> >+ [% IF message == "success_on_insert" %] >+ <form name="createlibrary" method="post" action="onboarding.pl"> >+ <input type="hidden" name="step" value="2"/> >+ <h1 align="left"> New Library</h1> >+ <div> >+ <p> Success: Library created! Your branchcode is [% branchcode %]</p> >+ <p> To add another library and for more settings, <br> >+ go to Tools->Administration->Libraries and Groups >+ </div> >+ Next up: >+ <input type="submit" name="start" value="Add a patron category"/> >+ </form> >+ >+ [%ELSE %] >+ <!--Implement if statement to determine if library was succesfully created here....--> >+ <form name="retrylibrary" method="post" action="onboarding.pl"> >+ <input type="hidden" name="step" value="1"/> >+ <h1 align="left">Failed </h1> >+ <div> >+ <p> Library was not successfully created</br> >+ Please try again or contact your system administrator. </p> >+ </div> >+ <input type="submit" value="Try again"/> >+ </form> >+ [%END%] > [% ELSE %] > <!--Create a library screen 1--> > <h2>Create a Library</h2> > <form name="LibraryCreation" method="post" action="onboarding.pl"> > <fieldset class="rows"> > <input type="hidden" name="step" value="1"/> >- <input type="hidden" name="op" value="add_validate" /> > <input type="hidden" name="createlibrary" value="createlibrary"/> > <ol> > <li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt >index ebad7d3..5808346 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt >@@ -18,6 +18,8 @@ > var MSG_ONE_ENROLLMENTPERIOD = ("Please choose an enrollment period in months OR by date."); > </script> > <script type="text/javascript" src="[% themelang %]/js/categories.js"></script> >+<style type="text/css">#enrolmentmessage.hint { display : none; }</style> >+ > </head> > > <div> <!-- Header that appears at the top of every screen in the koha onboarding tool--> >@@ -37,18 +39,32 @@ > </form> > > <!--else if the user has not previously imported sample patron categories check if the user has pressed the button name="add_validate" in the create patron category screen 1, and if they have pressed that button then display the below screen with a button to redirect the user to step 3--> >-[% ELSIF op == 'add_validate' %] >- <form name="createpatroncategory" method="post" action="onboarding.pl"> >- <input type="hidden" name="step" value="3"/> >+[% ELSIF op == "add_validate" %] >+ [% IF message != "error_on_insert" %] >+ <form name="createcat" method="post" action="onboarding.pl"> >+ Message is [%message%] >+ <input type="hidden" name="step" value="3"/> > <h1 align="left"> New patron category</h1> > <div> >- <p> Success: Patron category created!</p> >+ <p> Success: Patron category created! Your patron category code is [% category.categorycode %] </p> > <p> To add another patron category and for more settings<br> > go to More->Administration->Patrons & Circulation->Patron Categories</p> > </div> > Next up:<br> > <input type="submit" name="start" value="Add a patron"><!-- When the user clicks on this button then redirect them to step 3 of the onboarding tool--> > </form> >+ [% ELSE %] >+ <form name="retrypatcat" method="post" action="onboarding.pl"> >+ Message is [% message %] >+ <input type="hidden" name="step" value="2"/> >+ <h1 align="left">Failed</h1> >+ <div>Patron Category was not successfully created.</br> >+ Please try again or contact your system administrator.</p> >+ </div> >+ <input type="submit" value="Try again"/> >+ </form> >+ [% END %] >+ > > [% ELSE %] <!--Else display create patron category screen 1 where the user can input values to create their first patron category--> > <h1 align="left"> Create a new Patron Category</h2> >@@ -85,12 +101,6 @@ > <li> > <label for="category_type" class="required">Category type: </label> > <select name="category_type" value="category_type" class='required' required='required'> >- [% UNLESS category %] >- <option value="" selected="selected">Select a category type</option> >- [% ELSE %] >- <option value="">Select a category type</option> >- [% END %] >- > [% IF category and category.category_type == 'A' %] > <option value="A" selected="selected">Adult</ option> > [% ELSE %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt >index 37ffda8..e33b5bc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt >@@ -30,7 +30,6 @@ > <form name="patrondone" method="post" action="onboarding.pl"> > <input type="hidden" name="step" value="4"/> > <h1 align="left"> New Patron </h1> >- > <div> > <p> Success: New patron created!</p> > <p> To create another patron, go to Patrons > New Patron. <br> >@@ -54,7 +53,8 @@ > <h3>Patron Identity</h3> > <li> > <label for="surname" class="required">Surname: </label> >- <input style="text-transform:uppercase;" type="text" id="surname" name="surname" size="0" value="[% surname %]" class="required" required="required" /> >+ >+ <input type="text" id="surname" name="surname" value="[% surname %]" class="required" required="required" /> > <span class="required">Required</span> > </li> > <li> >@@ -74,10 +74,10 @@ > <li> > <!--require a foreach loop to get all the values for the library that the user has either imported (in web installer) or created in the first step of this onboarding tool--> > <label for="libraries" class="required"> Library: </label> >- <select name="branchcode" size="1" id="libraries"> >+ <select name="libraries" size="1" id="libraries"> > > [% FOREACH library IN libraries %] >- <option value="[% library.branchcode %]"> [% library.branchname %] >+ <option name="libraries" value="[% library.branchcode %]"> [% library.branchname %] > [% END %] > > </select> >@@ -85,15 +85,25 @@ > </li> > <li> > <label for="categorycode_entry" class="required"> Patron Category</label> >- <select id="categorycode_entry" name="categorycode" onchange="update_category_code(this);"> >- [% FOREACH category IN categories %] >- <option value = "[% category.description %]"> [%category.description %] >- [% END %] >+ <select id="categorycode_entry" name="categorycode_entry" onchange="update_category_code(this);"> >+ [% FOREACH category IN categories %] >+ <option name="categorycode_entry" value = "[% category.categorycode %]"> [%category.categorycode %]</option> >+ [% END %] > </select> > <span class="required">Required</span> > </li> > </ol> >- <ol> >+ >+ <ol> >+ >+ <h3> Patron permissions</h3> >+ <input type="hidden" name="newflags" value="1"/> >+ <li> >+ <input type="hidden" class="flag parent" id="flag-0" name="flag" value="superlibrarian"/> >+ <label name="permissioncode" for="flag-0"> superlibrarian</label> >+ </li> >+ </ol> >+ <ol> > <h3>OPAC/Staff Login</h3> > <li> > <label for="userid" class="required">Username: </label> >@@ -101,8 +111,8 @@ > <span class="required">Required</span> > </li> > <li> >- <label for="password" class="required">Password: </label> >- <input type="password" name="password" id="password" size="20" value="[% password %]" class="required" required="required"> >+ <label for="passwordlabel" class="required">Password: </label> >+ <input type="password" name="password" id="password" size="20" value="[% member.password |html %]" class="required" required="required"> > <span class="required">Required</span> > </li> > <li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt >index a4f0dab..380488f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt >@@ -20,7 +20,9 @@ > > [% IF itemtypes.count > 0 %] > <br> >- <h3 align="left">You do not need to create a item type as you have already installed the sample item type data previously</h3> >+ h no! Patron was not created</p> >+ >+ <h3 align="left">You do not need to create a item type as you have already installed the sample item type data previously</h3> > <form name="skipitemtype" method="post" action="onboarding.pl"> > <input type="hidden" name="step" value="5"/> > <div> >@@ -32,26 +34,34 @@ > <!--Create a item type screen 2--> > [% ELSIF op == "add_validate" %] > <!--New item type created--> >- <form name="createitemtype" method="post" action="onboarding.pl"> >- <input type="hidden" name="step" value="5"/> >- <h1 align="left"> New Item type </h1> >- >- <div> >- <p> Success: New item type created!</p> >- <p> To create another item type later and for more setttings <br> >- go to More->Administration->Item types >- </div> >- Next up: >- <input type="submit" value="Add a circulation rule"/> >- </form> >+ [% IF message != "error_on_insert" %] >+ <form name="createitemtype" method="post" action="onboarding.pl"> >+ <input type="hidden" name="step" value="5"/> >+ <h1 align="left"> New Item type </h1> >+ >+ <div> >+ <p> Success: New item type created!</p> >+ <p> To create another item type later and for more setttings <br> >+ go to More->Administration->Item types >+ </div> >+ Next up: >+ <input type="submit" value="Add a circulation rule"/> >+ </form> >+ [% ELSE %] >+ <form name="retryitem" method="post" action="onboarding.pl"> >+ <input type="hidden" name="step" value="4"/> >+ <h1 align="left">Failed </h1> >+ <div> >+ <p>Item type was not successfully created. </br> >+ Please try again or contact your system administrator. </p> >+ </div> >+ </form> > <!--Implement a if statement to check if the item type was successfully created or not >- <div> >- <p> Oh no! Patron was not created</p> >- </div>--> >+--> [% END %] > [% ELSE %] > <!--Create a item type screen 1--> > <h1 align="left"> Create a new Item type </h2> >- <form name="createitemtype" method="post" action="onboarding.pl"> >+ <form name="createitemform" method="post" action="onboarding.pl"> > <fieldset class="rows"> > <input type="hidden" name="step" value="4"/> > <input type="hidden" name="op" value="add_validate" /> >@@ -63,7 +73,7 @@ > </li> > <li> > <label for="description" class="required">Description: </label> >- <input type="text" name="description" id="description" size="80" value="[% itemtype.description |html %]" class="required" required="required"> >+ <input type="text" name="description" id="description" size="42" value="[% itemtype.description |html %]" class="required" required="required"> > <span class="required">Required</span> > </li> > </ol> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17855
:
58657
|
58658
|
58659
|
58660
|
58661
|
58662
|
58663
|
58664
|
58665
|
58666
|
58667
|
58668
|
58669
|
58781
|
58782
|
58783
|
58784
|
58785
|
58792
|
58793
|
58794
|
58846
|
58860
|
58861
|
58862
|
58886
|
58892
|
58893
|
58894
|
58895
|
58896
|
58897
|
58898
|
58899
|
58900
|
58901
|
58902
|
58903
|
58904
|
58905
|
58906
|
58907
|
59037
|
59051
|
59140
|
59141
|
59174
|
59188
|
59277
|
59279
|
59280
|
59281
|
59628
|
59703
|
59705
|
59706
|
59707
|
59708
|
59709
|
59710
|
59711
|
59712
|
59742
|
59826
|
59830
|
59840
|
59841
|
59842
|
59856
|
59857
|
60092
|
61667
|
61668
|
61986
|
62186
|
62191
|
62192
|
62193
|
62220
|
62221
|
62222
|
62223
|
62231
|
62233
|
62234
|
62235
|
62236
|
62237
|
62238
|
62239
|
62240
|
62241
|
62242
|
62243
|
62251
|
62252
|
62253
|
62254
|
62255
|
62256
|
62257
|
62258
|
62259
|
62260
|
62261
|
62262
|
62263
|
62281
|
62282
|
62283
|
62284
|
62285
|
62286
|
62287
|
62288
|
62668
|
62669
|
62670
|
62671
|
62672
|
62673
|
62674
|
62675