Attachment 59051 Details for Bug 17855 – Bug 17855 - removing some errant warns

[patch] Bug 17855 - removing some errant warns

Bug-17855---removing-some-errant-warns.patch (text/plain), 1.90 KB, created by Liz Rea on 2017-01-17 02:47:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2017-01-17 02:47:36 UTC

Size: 1.90 KB

patch

obsolete

>From c4ca65613749ce13c176b5848a57e06d7a1d7846 Mon Sep 17 00:00:00 2001
>From: Liz Rea <liz@catalyst.net.nz>
>Date: Tue, 17 Jan 2017 15:46:59 +1300
>Subject: [PATCH] Bug 17855 - removing some errant warns
>
>Just removing some warns that crept in during debugging.
>---
> installer/onboarding.pl | 5 -----
> 1 file changed, 5 deletions(-)
>
>diff --git a/installer/onboarding.pl b/installer/onboarding.pl
>index 437657d..d7c2f75 100755
>--- a/installer/onboarding.pl
>+++ b/installer/onboarding.pl
>@@ -165,7 +165,6 @@ if ( $step && $step == 1 ) {
>     else {
>         $message = 'error_on_insert';
>     }
>-    warn $message;
>     $template->param( 'message' => $message );
> 
> #Check if the $step variable equals 2 i.e. the user has clicked to create a patron category in the create patron category screen 1
>@@ -249,7 +248,6 @@ elsif ( $step && $step == 3 ) {
>     #Find all patron records in the database and hand them to the template
>     my %currentpatrons = Koha::Patrons->search();
>     my $currentpatrons = values %currentpatrons;
>-    warn $currentpatrons;
>     $template->param( 'patrons' =>$currentpatrons);
> 
> 
>@@ -285,9 +283,7 @@ elsif ( $step && $step == 3 ) {
> #Incrementing the highest existing patron cardnumber to prevent duplicate cardnumber entry
>     my $exisiting_cardnumber = my $sth_search =
>       $dbh->prepare("SELECT MAX(cardnumber) FROM borrowers");
>-    warn $exisiting_cardnumber;
>     my $new_cardnumber = $exisiting_cardnumber + 1;
>-    warn $new_cardnumber;
>     $template->param( "newcardnumber" => $new_cardnumber );
> 
>     my $op = $input->param('op') // 'list';
>@@ -454,7 +450,6 @@ elsif ( $step && $step == 4 ) {
>   if ($op eq "add_validate"){
>         my $description   = $input->param('description');
>         my $itemtype_code = $input->param('itemtype');
>-        warn $description;
>         $itemtype_code = uc($itemtype_code);
> 
>   #Create a new itemtype object using the user inputted itemtype and description
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 17855: 58657 | 58658 | 58659 | 58660 | 58661 | 58662 | 58663 | 58664 | 58665 | 58666 | 58667 | 58668 | 58669 | 58781 | 58782 | 58783 | 58784 | 58785 | 58792 | 58793 | 58794 | 58846 | 58860 | 58861 | 58862 | 58886 | 58892 | 58893 | 58894 | 58895 | 58896 | 58897 | 58898 | 58899 | 58900 | 58901 | 58902 | 58903 | 58904 | 58905 | 58906 | 58907 | 59037 | 59051 | 59140 | 59141 | 59174 | 59188 | 59277 | 59279 | 59280 | 59281 | 59628 | 59703 | 59705 | 59706 | 59707 | 59708 | 59709 | 59710 | 59711 | 59712 | 59742 | 59826 | 59830 | 59840 | 59841 | 59842 | 59856 | 59857 | 60092 | 61667 | 61668 | 61986 | 62186 | 62191 | 62192 | 62193 | 62220 | 62221 | 62222 | 62223 | 62231 | 62233 | 62234 | 62235 | 62236 | 62237 | 62238 | 62239 | 62240 | 62241 | 62242 | 62243 | 62251 | 62252 | 62253 | 62254 | 62255 | 62256 | 62257 | 62258 | 62259 | 62260 | 62261 | 62262 | 62263 | 62281 | 62282 | 62283 | 62284 | 62285 | 62286 | 62287 | 62288 | 62668 | 62669 | 62670 | 62671 | 62672 | 62673 | 62674 | 62675