Bugzilla – Attachment 59338 Details for
Bug 17909
Add unit tests for authority merge
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17909: Followup - fix typos
Bug-17909-Followup---fix-typos.patch (text/plain), 2.29 KB, created by
Julian Maurice
on 2017-01-20 11:25:13 UTC
(
hide
)
Description:
Bug 17909: Followup - fix typos
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2017-01-20 11:25:13 UTC
Size:
2.29 KB
patch
obsolete
>From 738f2ffbf67f363bf1819d3ac0fb67f61e76af35 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Mon, 16 Jan 2017 13:03:21 +0000 >Subject: [PATCH] Bug 17909: Followup - fix typos > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >EDIT: > >Adjusted three small typos that did not disturb the test in its current >form, but do when we are fixing bugs on bug 17913. > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > t/db_dependent/Authorities/Merge.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Authorities/Merge.t b/t/db_dependent/Authorities/Merge.t >index 123577e381..55470cc70e 100755 >--- a/t/db_dependent/Authorities/Merge.t >+++ b/t/db_dependent/Authorities/Merge.t >@@ -38,7 +38,7 @@ set_mocks(); > # Framework operations > my ( $authtype1, $authtype2 ) = modify_framework(); > >-subtest 'Test merge A1 to A2 (withing same authtype)' => sub { >+subtest 'Test merge A1 to A2 (within same authtype)' => sub { > # Tests originate from bug 11700 > plan tests => 9; > >@@ -111,7 +111,7 @@ subtest 'Test merge A1 to modified A1' => sub { > compare_field_count( $MARC1, $biblio1, 1 ); > compare_field_order( $MARC1, $biblio1, 1 ); > is( $auth1new->field(109)->subfield('a'), $biblio1->field(109)->subfield('a'), 'Record1 values updated correctly' ); >- my $biblio2 = GetMarcBiblio($biblionumber1); >+ my $biblio2 = GetMarcBiblio( $biblionumber2 ); > compare_field_count( $MARC2, $biblio2, 1 ); > compare_field_order( $MARC2, $biblio2, 1 ); > is( $auth1new->field(109)->subfield('a'), $biblio2->field(109)->subfield('a'), 'Record2 values updated correctly' ); >@@ -233,7 +233,7 @@ sub modify_framework { > }, > }); > >- # Link 112/712 to the second authtype >+ # Link 112/612 to the second authtype > $builder->build({ > source => 'MarcSubfieldStructure', > value => { >@@ -246,7 +246,7 @@ sub modify_framework { > $builder->build({ > source => 'MarcSubfieldStructure', > value => { >- tagfield => '712', >+ tagfield => '612', > tagsubfield => 'a', > authtypecode => $authtype2->{authtypecode}, > frameworkcode => '', >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17909
:
59005
|
59006
|
59007
|
59008
|
59011
|
59012
|
59013
|
59014
|
59015
|
59077
|
59088
|
59323
|
59324
|
59334
|
59335
|
59336
|
59337
| 59338 |
59339
|
59340